Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751387AbcDONlj (ORCPT ); Fri, 15 Apr 2016 09:41:39 -0400 Received: from szxga03-in.huawei.com ([119.145.14.66]:28699 "EHLO szxga03-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751116AbcDONli (ORCPT ); Fri, 15 Apr 2016 09:41:38 -0400 Subject: Re: [PATCH v2 0/6] perf tools: Use SIGUSR2 control data dumpping To: Arnaldo Carvalho de Melo , Adrian Hunter References: <1460643725-167413-1-git-send-email-wangnan0@huawei.com> <20160415001939.GL9056@kernel.org> <5710E932.8070804@intel.com> <20160415133547.GO9056@kernel.org> CC: , , "Arnaldo Carvalho de Melo" , Jiri Olsa , Masami Hiramatsu , Namhyung Kim , Zefan Li , He Kuang From: "Wangnan (F)" Message-ID: <5710EF70.8070701@huawei.com> Date: Fri, 15 Apr 2016 21:41:04 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.5.0 MIME-Version: 1.0 In-Reply-To: <20160415133547.GO9056@kernel.org> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.111.66.109] X-CFilter-Loop: Reflected X-Mirapoint-Virus-RAPID-Raw: score=unknown(0), refid=str=0001.0A020203.5710EF8A.0060,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0, ip=0.0.0.0, so=2013-05-26 15:14:31, dmn=2013-03-21 17:37:32 X-Mirapoint-Loop-Id: 29379001b9bdd76d220d9c129168bcb0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 5068 Lines: 120 On 2016/4/15 21:35, Arnaldo Carvalho de Melo wrote: > Em Fri, Apr 15, 2016 at 04:14:26PM +0300, Adrian Hunter escreveu: >> On 15/04/16 03:19, Arnaldo Carvalho de Melo wrote: >>> Em Thu, Apr 14, 2016 at 02:21:59PM +0000, Wang Nan escreveu: >>>> This patch set is based on perf/core. >>>> >>>> v1 -> v2: Fix a bug which triggers output switching without >>>> '--switch-output' provided. >>>> >>>> Patch 5/10 in v1 has a bug: with following cmdline: >>>> # perf record -e intel_bts// --per-thread --snapshot -p 13588 >>> Ok, I moved the trigger stuff to a new file, util/trigger.h and added >>> missing man page entries, pushed to acme/perf/core, please take a look >>> if all is well before I push this to Ingo, tomorrow. >>> >>> Adrian/others, if you can, please take a look. >> Looks OK. I gave intel_pt a quick test with snapshot mode which didn't seem >> to be broken. >> >> Using --switch-output with intel_pt gives data that does not decode in the >> 2nd and subsequent files because there is no continuity of switch events. >> Also decoding the last file segfaults because the auxtrace index has not >> been split between the files. >> Probably need to prevent people using --switch-output with intel_pt, but >> I'll look at it more next week. > But the workflow of continuous tracing with regular analysis to go on > dumping uninteresting sections of the trace seems interesting? With the > massive volumes of data with Intel PT continuous tracing is deemded > impossible? Another question: is it possible to make auxtrace (intel_bts, intel_bt and coresight) writing to overwritable ring buffer, so we can continuous trace them and silently drop uninteresting data? Thank you. > - Arnaldo > >>> - Arnaldo >>> >>>> Sending 'SIGUSR2' to perf triggers output switching, which us >>>> undesirable. The reason is in signal handler perf doesn't consider if >>>> user provided --switch-output explicitly. >>>> >>>> With this patchset applied: >>>> >>>> # /perf record --switch-output -e intel_bts// --per-thread --snapshot -p 13588 & >>>> [1] 15116 >>>> # kill -s SIGUSR2 15116 >>>> # [ perf record: dump data: Woken up 5 times ] >>>> [ perf record: Dump perf.data.2016041506170000 ] >>>> >>>> # kill -s SIGUSR2 15116 >>>> # [ perf record: dump data: Woken up 3 times ] >>>> [ perf record: Dump perf.data.2016041506170447 ] >>>> >>>> # fg >>>> /perf record --switch-output -e intel_bts// --per-thread --snapshot -p 13588 >>>> ^C[ perf record: Woken up 3 times to write data ] >>>> [ perf record: Dump perf.data.2016041506170785 ] >>>> [ perf record: Captured and wrote 0.012 MB perf.data. ] >>>> >>>> # ls -l ./perf.data* >>>> -rw------- 1 root root 4212888 Apr 15 06:17 ./perf.data.2016041506170000 >>>> -rw------- 1 root root 4212704 Apr 15 06:17 ./perf.data.2016041506170447 >>>> -rw------- 1 root root 18368 Apr 15 06:17 ./perf.data.2016041506170785 >>>> >>>> The first 2 perf.data works fine. The final one has no samples. >>>> >>>> And: >>>> # rm ./perf.data* >>>> # /perf record -e intel_bts// --per-thread --snapshot -p 13588 & >>>> [1] 15396 >>>> # kill -s SIGUSR2 15396 >>>> # kill -s SIGUSR2 15396 >>>> # fg >>>> /perf record -e intel_bts// --per-thread --snapshot -p 13588 >>>> ^C[ perf record: Woken up 9 times to write data ] >>>> [ perf record: Captured and wrote 8.012 MB perf.data ] >>>> >>>> # ls -l ./perf.data* >>>> -rw------- 1 root root 8417552 Apr 15 06:20 ./perf.data >>>> >>>> (In v1, the second test trigger output switching incorrectly) >>>> >>>> Patch 1-2/6 in this patchset makes switch output trigger similar to >>>> auxtrace snapshot trigger. Patch 1/6 introduces a 'trigger' class for >>>> them. It would be better to merge patch 1/6 with commit c0bdc1c ("perf >>>> record: Turns auxtrace_snapshot_enable into 3 states"). However, Ingo >>>> has collected that commit, so make it a separated patch. >>>> >>>> Signed-off-by: Wang Nan >>>> Cc: Arnaldo Carvalho de Melo >>>> Cc: Adrian Hunter >>>> Cc: Jiri Olsa >>>> Cc: Masami Hiramatsu >>>> Cc: Namhyung Kim >>>> Cc: Zefan Li >>>> Cc: pi3orama@163.com >>>> Cc: He Kuang >>>> >>>> Wang Nan (6): >>>> perf tools: Extrace trigger class from auxtrace_snapshot >>>> perf record: Split output into multiple files via '--switch-output' >>>> perf record: Force enable --timestamp-filename when --switch-output is >>>> provided >>>> perf record: Disable buildid cache options by default in switch output >>>> mode >>>> perf record: Re-synthesize tracking events after output switching >>>> perf record: Generate tracking events for process forked by perf >>>> >>>> tools/perf/builtin-record.c | 147 +++++++++++++++++++++++++++++++------------- >>>> tools/perf/util/util.h | 60 ++++++++++++++++++ >>>> 2 files changed, 163 insertions(+), 44 deletions(-) >>>> >>>> -- >>>> 1.8.3.4