Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752235AbcDOO4X (ORCPT ); Fri, 15 Apr 2016 10:56:23 -0400 Received: from mx1.redhat.com ([209.132.183.28]:57803 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752176AbcDOO4T (ORCPT ); Fri, 15 Apr 2016 10:56:19 -0400 From: Jeff Moyer To: Vishal Verma Cc: linux-nvdimm@ml01.01.org, Jens Axboe , Jan Kara , Andrew Morton , Christoph Hellwig , Dave Chinner , linux-kernel@vger.kernel.org, xfs@oss.sgi.com, linux-block@vger.kernel.org, linux-mm@kvack.org, Matthew Wilcox , linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, Al Viro Subject: Re: [PATCH v2 3/5] dax: enable dax in the presence of known media errors (badblocks) References: <1459303190-20072-1-git-send-email-vishal.l.verma@intel.com> <1459303190-20072-4-git-send-email-vishal.l.verma@intel.com> X-PGP-KeyID: 1F78E1B4 X-PGP-CertKey: F6FE 280D 8293 F72C 65FD 5A58 1FF8 A7CA 1F78 E1B4 X-PCLoadLetter: What the f**k does that mean? Date: Fri, 15 Apr 2016 10:56:10 -0400 In-Reply-To: <1459303190-20072-4-git-send-email-vishal.l.verma@intel.com> (Vishal Verma's message of "Tue, 29 Mar 2016 19:59:48 -0600") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1879 Lines: 60 Vishal Verma writes: > From: Dan Williams > > 1/ If a mapping overlaps a bad sector fail the request. > > 2/ Do not opportunistically report more dax-capable capacity than is > requested when errors present. > > [vishal: fix a conflict with system RAM collision patches] > Signed-off-by: Dan Williams Reviewed-by: Jeff Moyer > --- > block/ioctl.c | 9 --------- > drivers/nvdimm/pmem.c | 8 ++++++++ > 2 files changed, 8 insertions(+), 9 deletions(-) > > diff --git a/block/ioctl.c b/block/ioctl.c > index d8996bb..cd7f392 100644 > --- a/block/ioctl.c > +++ b/block/ioctl.c > @@ -423,15 +423,6 @@ bool blkdev_dax_capable(struct block_device *bdev) > || (bdev->bd_part->nr_sects % (PAGE_SIZE / 512))) > return false; > > - /* > - * If the device has known bad blocks, force all I/O through the > - * driver / page cache. > - * > - * TODO: support finer grained dax error handling > - */ > - if (disk->bb && disk->bb->count) > - return false; > - > return true; > } > #endif > diff --git a/drivers/nvdimm/pmem.c b/drivers/nvdimm/pmem.c > index da10554..eac5f93 100644 > --- a/drivers/nvdimm/pmem.c > +++ b/drivers/nvdimm/pmem.c > @@ -174,9 +174,17 @@ static long pmem_direct_access(struct block_device *bdev, > struct pmem_device *pmem = bdev->bd_disk->private_data; > resource_size_t offset = sector * 512 + pmem->data_offset; > > + if (unlikely(is_bad_pmem(&pmem->bb, sector, dax->size))) > + return -EIO; > dax->addr = pmem->virt_addr + offset; > dax->pfn = phys_to_pfn_t(pmem->phys_addr + offset, pmem->pfn_flags); > > + /* > + * If badblocks are present, limit known good range to the > + * requested range. > + */ > + if (unlikely(pmem->bb.count)) > + return dax->size; > return pmem->size - pmem->pfn_pad - offset; > }