Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751851AbcDOQBE (ORCPT ); Fri, 15 Apr 2016 12:01:04 -0400 Received: from mail.kernel.org ([198.145.29.136]:60756 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750970AbcDOQBC (ORCPT ); Fri, 15 Apr 2016 12:01:02 -0400 Date: Fri, 15 Apr 2016 13:00:57 -0300 From: Arnaldo Carvalho de Melo To: Jiri Olsa Cc: Wang Nan , linux-kernel@vger.kernel.org, pi3orama@163.com, He Kuang , Arnaldo Carvalho de Melo , Jiri Olsa , Masami Hiramatsu , Namhyung Kim , Zefan Li Subject: Re: [PATCH 02/10] perf tools: Add perf_data_file__switch() helper Message-ID: <20160415160057.GQ9056@kernel.org> References: <1460535673-159866-1-git-send-email-wangnan0@huawei.com> <1460535673-159866-3-git-send-email-wangnan0@huawei.com> <20160415104108.GB2970@krava> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160415104108.GB2970@krava> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1531 Lines: 42 Em Fri, Apr 15, 2016 at 12:41:08PM +0200, Jiri Olsa escreveu: > On Wed, Apr 13, 2016 at 08:21:05AM +0000, Wang Nan wrote: > > perf_data_file__switch() closes current output file, renames it, then > > open a new one to continue recording. It will be used by perf record > > to split output into multiple perf.data files. > > > > Signed-off-by: Wang Nan > > Signed-off-by: He Kuang > > Cc: Arnaldo Carvalho de Melo > > Cc: Jiri Olsa > > Cc: Masami Hiramatsu > > Cc: Namhyung Kim > > Cc: Zefan Li > > Cc: pi3orama@163.com > > --- > > tools/perf/util/data.c | 41 +++++++++++++++++++++++++++++++++++++++++ > > tools/perf/util/data.h | 11 ++++++++++- > > 2 files changed, 51 insertions(+), 1 deletion(-) > > > > diff --git a/tools/perf/util/data.c b/tools/perf/util/data.c > > index 1921942..be835161 100644 > > --- a/tools/perf/util/data.c > > +++ b/tools/perf/util/data.c > > @@ -136,3 +136,44 @@ ssize_t perf_data_file__write(struct perf_data_file *file, > > { > > return writen(file->fd, buf, size); > > } > > + > > +int perf_data_file__switch(struct perf_data_file *file, > > + const char *postfix, > > + size_t pos, bool at_exit) > > could you please rename at_exit to reopen > > I guess you follow the record object's at_exit naming, > but 'reopen' seems more clear to me > I'll rename this, if not yet pushed to Ingo, checking... - Arnaldo > jirka