Subject: Re: [PATCH V3] blackfin: optimize ffz, __ffs, ffs, __fls, and fls
 functions
To: Joe Perches <joe@perches.com>, linux-kernel@vger.kernel.org
References: <1460706724-15953-1-git-send-email-zengzhaoxiu@163.com>
 <1460733645-77406-1-git-send-email-zengzhaoxiu@163.com>
 <1460736514.19090.32.camel@perches.com>
Cc: Zeng Zhaoxiu <zhaoxiu.zeng@gmail.com>, Steven Miao <realmz6@gmail.com>,
        adi-buildroot-devel@lists.sourceforge.net
From: Zhaoxiu Zeng <zengzhaoxiu@163.com>
Message-ID: <57111463.9090109@163.com>
Date: Sat, 16 Apr 2016 00:18:43 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:38.0) Gecko/20100101
 Thunderbird/38.7.2
MIME-Version: 1.0
In-Reply-To: <1460736514.19090.32.camel@perches.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 792
Lines: 24

在 2016/4/16 0:08, Joe Perches 写道:
> On Fri, 2016-04-15 at 23:20 +0800, zengzhaoxiu@163.com wrote:
>> From: Zeng Zhaoxiu <zhaoxiu.zeng@gmail.com>
>>
>> blackfin has popcount instruction (ONES), we can do the efficient
>> computing (ffz, __ffs, ffs, __fls, and fls) use this instruction.
> []
>> diff --git a/arch/blackfin/include/asm/bitops.h b/arch/blackfin/include/asm/bitops.h
> []
>> +static inline unsigned int __arch_hweight64(__u64 w)
>> +{
>> +	return __arch_hweight32((unsigned int)(w >> 32)) +
>> +	       __arch_hweight32((unsigned int)w);
>> +}
> trivia:  perhaps this is more readable as:
>
> 	return __arch_hweight32(upper_32_bits(w)) +
> 	       __arch_hweight32(lower_32_bits(w));
>
>

Yes.
I just moved these codes from the bottom of  bitops.h, didn't change anything.