Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752844AbcDOQ5h (ORCPT ); Fri, 15 Apr 2016 12:57:37 -0400 Received: from mail.kernel.org ([198.145.29.136]:37098 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751969AbcDOQ5f (ORCPT ); Fri, 15 Apr 2016 12:57:35 -0400 MIME-Version: 1.0 In-Reply-To: <1460668031-12384-1-git-send-email-john.stultz@linaro.org> References: <1460668031-12384-1-git-send-email-john.stultz@linaro.org> From: Rob Herring Date: Fri, 15 Apr 2016 11:57:12 -0500 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 1/2 v2] device-tree: nexus7-flo: Remove power gpio key entry and use pmic8xxx-pwrkey To: John Stultz Cc: lkml , Arnd Bergmann , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Andy Gross , Vinay Simha BN , Bjorn Andersson , Stephen Boyd , linux-arm-msm , "devicetree@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1431 Lines: 35 On Thu, Apr 14, 2016 at 4:07 PM, John Stultz wrote: > Since the pmic8xxx-pwrkey driver is already supported in the > qcom-apq8064.dtsi, and the pmic8xxx-pwrkey supports logic to > configure proper device shutdown when ps_hold goes low, it is > better to use that driver then a generic gpio button. > > Thus this patch remove the gpio power key entry here, so we > don't get double input events from having two drivers enabled. > > The one gotcha with the pmic8xxx-pwrkey is it has a fairly > long debounce delay, which we shorten here to make the button > behave as expected. > > Cc: Rob Herring > Cc: Arnd Bergmann > Cc: Pawel Moll > Cc: Mark Rutland > Cc: Ian Campbell > Cc: Kumar Gala > Cc: Andy Gross > Cc: Vinay Simha BN > Cc: Bjorn Andersson > Cc: Stephen Boyd > Cc: linux-arm-msm@vger.kernel.org > Cc: devicetree@vger.kernel.org > Signed-off-by: John Stultz > --- > v2: > - Add wakeup-source entry as suggested by > Sudeep Holla > > arch/arm/boot/dts/qcom-apq8064-asus-nexus7-flo.dts | 16 ++++++++++------ > 1 file changed, 10 insertions(+), 6 deletions(-) Acked-by: Rob Herring