Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752913AbcDORAh (ORCPT ); Fri, 15 Apr 2016 13:00:37 -0400 Received: from mga11.intel.com ([192.55.52.93]:17715 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752733AbcDORAe (ORCPT ); Fri, 15 Apr 2016 13:00:34 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.24,488,1455004800"; d="scan'208";a="785724089" From: "Verma, Vishal L" To: "Williams, Dan J" , "linux-nvdimm@lists.01.org" CC: "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] libnvdimm, btt: add btt startup debug Thread-Topic: [PATCH] libnvdimm, btt: add btt startup debug Thread-Index: AQHRlsBnYykeU3PqjUOvH2eea7yyZZ+LuHqA Date: Fri, 15 Apr 2016 17:00:31 +0000 Message-ID: <1460739631.3012.5.camel@intel.com> References: <146068804238.24085.7095431982077468731.stgit@dwillia2-desk3.jf.intel.com> In-Reply-To: <146068804238.24085.7095431982077468731.stgit@dwillia2-desk3.jf.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.254.176.69] Content-Type: text/plain; charset="utf-8" Content-ID: <1036724346561C409298E467582E4B84@intel.com> MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id u3FH0pD0003790 Content-Length: 1313 Lines: 41 On Thu, 2016-04-14 at 19:40 -0700, Dan Williams wrote: > Report the reason for btt probe failures when debug is enabled. > > Signed-off-by: Dan Williams > --- >  drivers/nvdimm/btt.c |    6 +++++- >  1 file changed, 5 insertions(+), 1 deletion(-) Reveiwed-by: Vishal Verma > > diff --git a/drivers/nvdimm/btt.c b/drivers/nvdimm/btt.c > index cc9fafed9362..68a7c3c1eed9 100644 > --- a/drivers/nvdimm/btt.c > +++ b/drivers/nvdimm/btt.c > @@ -1383,11 +1383,15 @@ int nvdimm_namespace_attach_btt(struct > nd_namespace_common *ndns) >   struct btt *btt; >   size_t rawsize; >   > - if (!nd_btt->uuid || !nd_btt->ndns || !nd_btt->lbasize) > + if (!nd_btt->uuid || !nd_btt->ndns || !nd_btt->lbasize) { > + dev_dbg(&nd_btt->dev, "incomplete btt > configuration\n"); >   return -ENODEV; > + } >   >   rawsize = nvdimm_namespace_capacity(ndns) - SZ_4K; >   if (rawsize < ARENA_MIN_SIZE) { > + dev_dbg(&nd_btt->dev, "%s must be at least %ld > bytes\n", > + dev_name(&ndns->dev), ARENA_MIN_SIZE > + SZ_4K); >   return -ENXIO; >   } >   nd_region = to_nd_region(nd_btt->dev.parent); > > _______________________________________________ > Linux-nvdimm mailing list > Linux-nvdimm@lists.01.org > https://lists.01.org/mailman/listinfo/linux-nvdimm