Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753090AbcDORAn (ORCPT ); Fri, 15 Apr 2016 13:00:43 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:48937 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752916AbcDORAk (ORCPT ); Fri, 15 Apr 2016 13:00:40 -0400 Subject: Re: [PATCH 1/2] [v4] net: emac: emac gigabit ethernet controller driver To: Bjorn Andersson Cc: Vikram Sethi , Florian Fainelli , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, sdharia@codeaurora.org, Shanker Donthineni , Greg Kroah-Hartman , cov@codeaurora.org, gavidov@codeaurora.org, Rob Herring , andrew@lunn.ch, Mark Langsdorf , Jon Masters , Andy Gross , "David S. Miller" References: <1460570393-19838-1-git-send-email-timur@codeaurora.org> <570EC541.6080603@gmail.com> <570FFB6B.5060305@codeaurora.org> <57100962.40404@gmail.com> <571012E6.6050303@codeaurora.org> <57102920.7000104@codeaurora.org> <20160415164433.GV391@tuxbot> From: Timur Tabi Message-ID: <57111E33.606@codeaurora.org> Date: Fri, 15 Apr 2016 12:00:35 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:43.0) Gecko/20100101 Firefox/43.0 SeaMonkey/2.40 MIME-Version: 1.0 In-Reply-To: <20160415164433.GV391@tuxbot> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 880 Lines: 22 Bjorn Andersson wrote: > For platform devices being populated via from DT you will pass: > of_platform_bus_create() > of_platform_device_create_pdata() > of_dma_configure() > > Which calls of_dma_get_range() to acquire this information from the > dma-ranges property and set up the dma ops and properties. This seems excessive. I have to create a platform bus just to configure the DMA mask? Most drivers just call dma_set_mask and give it a number, and that's not device-tree specific. I also need to come up with a way to get this to work on ACPI. I just seems like a lot of work only because I need to determine at runtime what my DMA mask is. I also don't see any drivers that call of_dma_configure(). -- Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation collaborative project.