Message-ID: <1460740238.19090.35.camel@perches.com>
Subject: Re: [PATCH] x86: fix non-static inlines
From: Joe Perches <joe@perches.com>
To: Denys Vlasenko <dvlasenk@redhat.com>, Ingo Molnar <mingo@kernel.org>
Cc: Andy Lutomirski <luto@amacapital.net>, "H. Peter Anvin" <hpa@zytor.com>,
        Borislav Petkov <bp@alien8.de>, Brian Gerst <brgerst@gmail.com>,
        x86@kernel.org, linux-kernel@vger.kernel.org
Date: Fri, 15 Apr 2016 10:10:38 -0700
In-Reply-To: <1460739626-12179-1-git-send-email-dvlasenk@redhat.com>
References: <1460739626-12179-1-git-send-email-dvlasenk@redhat.com>
Content-Type: text/plain; charset="ISO-8859-1"
Mime-Version: 1.0
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 624
Lines: 16

On Fri, 2016-04-15 at 19:00 +0200, Denys Vlasenko wrote:
> Four instances of incorrect usage of non-static "inline" crept up
> in arch/x86, all trivial; cleaning them up:

Thanks and trivia:

> diff --git a/arch/x86/crypto/sha-mb/sha1_mb.c b/arch/x86/crypto/sha-mb/sha1_mb.c
[]
> @@ -102,14 +102,14 @@ static asmlinkage struct job_sha1* (*sha1_job_mgr_submit)(struct sha1_mb_mgr *st
[]
> -inline uint32_t sha1_pad(uint8_t padblock[SHA1_BLOCK_SIZE * 2],
> +static inline uint32_t sha1_pad(uint8_t padblock[SHA1_BLOCK_SIZE * 2],
> ?			?uint32_t total_len)

It'd be good to reindent the multi-line statements
at the same time.