Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932331AbcDOTi0 (ORCPT ); Fri, 15 Apr 2016 15:38:26 -0400 Received: from vps0.lunn.ch ([178.209.37.122]:58016 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752617AbcDOTiU (ORCPT ); Fri, 15 Apr 2016 15:38:20 -0400 Date: Fri, 15 Apr 2016 21:38:18 +0200 From: Andrew Lunn To: Vivien Didelot Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel@savoirfairelinux.com, "David S. Miller" , Florian Fainelli Subject: Re: [PATCH net-next 7/7] net: dsa: mv88e6xxx: drop switch id Message-ID: <20160415193818.GE18523@lunn.ch> References: <1460744750-13896-1-git-send-email-vivien.didelot@savoirfairelinux.com> <1460744750-13896-8-git-send-email-vivien.didelot@savoirfairelinux.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1460744750-13896-8-git-send-email-vivien.didelot@savoirfairelinux.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2626 Lines: 73 On Fri, Apr 15, 2016 at 02:25:50PM -0400, Vivien Didelot wrote: > We already have the product number and revision stored in the info > structure and the switch private state. > > It is not necessary to clutter the header file with shifted product > number for devices that we don't even support yet. Remove them. > > Signed-off-by: Vivien Didelot > --- > drivers/net/dsa/mv88e6xxx.c | 1 - > drivers/net/dsa/mv88e6xxx.h | 34 ---------------------------------- > 2 files changed, 35 deletions(-) > > diff --git a/drivers/net/dsa/mv88e6xxx.c b/drivers/net/dsa/mv88e6xxx.c > index d40ac4d..7ec87df 100644 > --- a/drivers/net/dsa/mv88e6xxx.c > +++ b/drivers/net/dsa/mv88e6xxx.c > @@ -3027,7 +3027,6 @@ found: > ps->bus = bus; > ps->sw_addr = sw_addr; > ps->info = info; > - ps->id = id & 0xfff0; > ps->rev = id & 0xf; > > dev_info(&ps->bus->dev, "found switch %s, revision %u\n", > diff --git a/drivers/net/dsa/mv88e6xxx.h b/drivers/net/dsa/mv88e6xxx.h > index 7e86cc6..fb81945 100644 > --- a/drivers/net/dsa/mv88e6xxx.h > +++ b/drivers/net/dsa/mv88e6xxx.h > @@ -68,39 +68,6 @@ > #define PORT_PCS_CTRL_UNFORCED 0x03 > #define PORT_PAUSE_CTRL 0x02 > #define PORT_SWITCH_ID 0x03 > -#define PORT_SWITCH_ID_PROD_NUM_MASK 0xfff0 > -#define PORT_SWITCH_ID_REV_MASK 0x000f > -#define PORT_SWITCH_ID_6031 0x0310 > -#define PORT_SWITCH_ID_6035 0x0350 > -#define PORT_SWITCH_ID_6046 0x0480 > -#define PORT_SWITCH_ID_6061 0x0610 > -#define PORT_SWITCH_ID_6065 0x0650 > -#define PORT_SWITCH_ID_6085 0x04a0 > -#define PORT_SWITCH_ID_6092 0x0970 > -#define PORT_SWITCH_ID_6095 0x0950 > -#define PORT_SWITCH_ID_6096 0x0980 > -#define PORT_SWITCH_ID_6097 0x0990 > -#define PORT_SWITCH_ID_6108 0x1070 > -#define PORT_SWITCH_ID_6121 0x1040 > -#define PORT_SWITCH_ID_6122 0x1050 > -#define PORT_SWITCH_ID_6123 0x1210 > -#define PORT_SWITCH_ID_6131 0x1060 > -#define PORT_SWITCH_ID_6152 0x1a40 > -#define PORT_SWITCH_ID_6155 0x1a50 > -#define PORT_SWITCH_ID_6161 0x1610 > -#define PORT_SWITCH_ID_6165 0x1650 > -#define PORT_SWITCH_ID_6171 0x1710 > -#define PORT_SWITCH_ID_6172 0x1720 > -#define PORT_SWITCH_ID_6175 0x1750 > -#define PORT_SWITCH_ID_6176 0x1760 > -#define PORT_SWITCH_ID_6182 0x1a60 > -#define PORT_SWITCH_ID_6185 0x1a70 > -#define PORT_SWITCH_ID_6240 0x2400 > -#define PORT_SWITCH_ID_6320 0x1150 > -#define PORT_SWITCH_ID_6321 0x3100 > -#define PORT_SWITCH_ID_6350 0x3710 > -#define PORT_SWITCH_ID_6351 0x3750 > -#define PORT_SWITCH_ID_6352 0x3520 NACK These numbers are not obvious. PORT_SWITCH_ID_6320 i can understand. 0x1150 i have no idea what it is. Andrwe