Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751414AbcDOUYc (ORCPT ); Fri, 15 Apr 2016 16:24:32 -0400 Received: from mail.savoirfairelinux.com ([208.88.110.44]:60228 "EHLO mail.savoirfairelinux.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750832AbcDOUYa (ORCPT ); Fri, 15 Apr 2016 16:24:30 -0400 From: Vivien Didelot To: Andrew Lunn Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel@savoirfairelinux.com, "David S. Miller" , Florian Fainelli Subject: Re: [PATCH net-next 6/7] net: dsa: mv88e6xxx: add number of database to info In-Reply-To: <20160415193516.GD18523@lunn.ch> References: <1460744750-13896-1-git-send-email-vivien.didelot@savoirfairelinux.com> <1460744750-13896-7-git-send-email-vivien.didelot@savoirfairelinux.com> <20160415193516.GD18523@lunn.ch> User-Agent: Notmuch/0.21 (http://notmuchmail.org) Emacs/24.5.1 (x86_64-unknown-linux-gnu) Date: Fri, 15 Apr 2016 16:24:26 -0400 Message-ID: <87mvouaadh.fsf@ketchup.mtl.sfl> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 687 Lines: 26 Hi Andrew, Andrew Lunn writes: > On Fri, Apr 15, 2016 at 02:25:49PM -0400, Vivien Didelot wrote: >> Move the number of databases to the info structure. > > Isn't the number of databases a property of the family? No. We've seen [1] for instance that 6061 and 6065 are both part of the 6065 family, but 6061 has 16 databases while 6065 has 64 databases. > I would add a table indexed by family. I'm not even sure every Marvell switch has a family. I think we really want a table of supported *devices*. To go further, with the coming feature-based logic, checking the family might not even be that valuable. [1] https://lkml.org/lkml/2016/3/26/155 Thanks, Vivien