Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1751621AbcDOU4a (ORCPT <rfc822;w@1wt.eu>);
	Fri, 15 Apr 2016 16:56:30 -0400
Received: from userp1040.oracle.com ([156.151.31.81]:28615 "EHLO
	userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751440AbcDOU41 (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Fri, 15 Apr 2016 16:56:27 -0400
To: James Bottomley <jejb@linux.vnet.ibm.com>
Cc: Johannes Thumshirn <jthumshirn@suse.de>,
        Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>,
        "Ewan D. Milne" <emilne@redhat.com>, Hannes Reinecke <hare@suse.com>,
        "Martin K. Petersen" <martin.petersen@oracle.com>,
        Stephen Rothwell <sfr@canb.auug.org.au>, linux-scsi@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org,
        linux-next@vger.kernel.org,
        Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
        Xiong Zhou <jencce.kernel@gmail.com>
Subject: Re: [-next] BUG_ON in scsi_target_destroy()
From: "Martin K. Petersen" <martin.petersen@oracle.com>
Organization: Oracle Corporation
References: <20160411090146.GA537@swordfish> <2201725.I2to9GCRQJ@c203>
	<1460560474.2322.3.camel@linux.vnet.ibm.com>
Date: Fri, 15 Apr 2016 16:55:55 -0400
In-Reply-To: <1460560474.2322.3.camel@linux.vnet.ibm.com> (James Bottomley's
	message of "Wed, 13 Apr 2016 08:14:34 -0700")
Message-ID: <yq1inzipp5w.fsf@sermon.lab.mkp.net>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-Source-IP: userv0021.oracle.com [156.151.31.71]
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 482
Lines: 12

>>>>> "James" == James Bottomley <jejb@linux.vnet.ibm.com> writes:

James> The STARGET_REMOVE state you added only applies to the case we're
James> trying to kill a target.  In the natural operation case, which is
James> what everyone else is running into, we will try to remove a
James> running target when it has no more scsi devices left on it.  So
James> the correct patch should be to make the BUG_ON see this:

Commit amended.

-- 
Martin K. Petersen	Oracle Linux Engineering