Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751621AbcDOU4a (ORCPT ); Fri, 15 Apr 2016 16:56:30 -0400 Received: from userp1040.oracle.com ([156.151.31.81]:28615 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751440AbcDOU41 (ORCPT ); Fri, 15 Apr 2016 16:56:27 -0400 To: James Bottomley Cc: Johannes Thumshirn , Sergey Senozhatsky , "Ewan D. Milne" , Hannes Reinecke , "Martin K. Petersen" , Stephen Rothwell , linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, linux-next@vger.kernel.org, Sergey Senozhatsky , Xiong Zhou Subject: Re: [-next] BUG_ON in scsi_target_destroy() From: "Martin K. Petersen" Organization: Oracle Corporation References: <20160411090146.GA537@swordfish> <2201725.I2to9GCRQJ@c203> <1460560474.2322.3.camel@linux.vnet.ibm.com> Date: Fri, 15 Apr 2016 16:55:55 -0400 In-Reply-To: <1460560474.2322.3.camel@linux.vnet.ibm.com> (James Bottomley's message of "Wed, 13 Apr 2016 08:14:34 -0700") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Source-IP: userv0021.oracle.com [156.151.31.71] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 482 Lines: 12 >>>>> "James" == James Bottomley writes: James> The STARGET_REMOVE state you added only applies to the case we're James> trying to kill a target. In the natural operation case, which is James> what everyone else is running into, we will try to remove a James> running target when it has no more scsi devices left on it. So James> the correct patch should be to make the BUG_ON see this: Commit amended. -- Martin K. Petersen Oracle Linux Engineering