Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751827AbcDOXCw (ORCPT ); Fri, 15 Apr 2016 19:02:52 -0400 Received: from mail-ig0-f196.google.com ([209.85.213.196]:33052 "EHLO mail-ig0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750967AbcDOXCu (ORCPT ); Fri, 15 Apr 2016 19:02:50 -0400 MIME-Version: 1.0 In-Reply-To: <1460734532-20134-14-git-send-email-ebiederm@xmission.com> References: <877ffyzy1j.fsf_-_@x220.int.ebiederm.org> <1460734532-20134-1-git-send-email-ebiederm@xmission.com> <1460734532-20134-14-git-send-email-ebiederm@xmission.com> Date: Fri, 15 Apr 2016 16:02:49 -0700 X-Google-Sender-Auth: vZ0ey-9gt3GxV3dmWETAAZVPnNw Message-ID: Subject: Re: [PATCH 14/16] vfs: Implement mount_super_once From: Linus Torvalds To: "Eric W. Biederman" Cc: "H. Peter Anvin" , Andy Lutomirski , security@debian.org, "security@kernel.org" , Al Viro , "security@ubuntu.com >> security" , Peter Hurley , Serge Hallyn , Willy Tarreau , Aurelien Jarno , One Thousand Gnomes , Jann Horn , Greg KH , Linux Kernel Mailing List , Jiri Slaby , Florian Weimer Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 844 Lines: 26 On Fri, Apr 15, 2016 at 8:35 AM, Eric W. Biederman wrote: > The devpts filesystem has a notion of a system or primary instance of > devpts. To retain the notion of a primary system instance of devpts > the code needs a way to allow userspace to mount the internally > mounted instance of devpts when it is not currently mounted by > userspace. The new helper mount_super_once allows that. This is where I stopped reading this patch series. No. We want to get *rid* of the idiotic "primary instance" crap. The whole and only point of doing the "which pts filesystem am I associated with" for ptmx is to stop the idiotic "one devpts is pecial". I don't want to see 16 random patches. I want to see *one* patch that makes /dev/ptmx look up the pts filesystem, and be done with it. Plonk. Linus