Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752325AbcDPANu (ORCPT ); Fri, 15 Apr 2016 20:13:50 -0400 Received: from shards.monkeyblade.net ([149.20.54.216]:53526 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751130AbcDPANt (ORCPT ); Fri, 15 Apr 2016 20:13:49 -0400 Date: Fri, 15 Apr 2016 20:13:40 -0400 (EDT) Message-Id: <20160415.201340.75308332414545478.davem@davemloft.net> To: wangweidong1@huawei.com Cc: f.fainelli@gmail.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, sergei.shtylyov@cogentembedded.com, andrew@lunn.ch Subject: Re: [PATCH net-next] phy: make some bits preserved while setup forced mode From: David Miller In-Reply-To: <570F4A38.5090201@huawei.com> References: <570E3488.9060403@huawei.com> <570F4A38.5090201@huawei.com> X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Fri, 15 Apr 2016 17:13:48 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 499 Lines: 16 From: Weidong Wang Date: Thu, 14 Apr 2016 15:43:52 +0800 > When tested the PHY SGMII Loopback: > 1.set the LOOPBACK bit, > 2.set the autoneg to AUTONEG_DISABLE, it calls the > genphy_setup_forced which will clear the bit. > > The BMCR_LOOPBACK bit should be preserved. > > As Florian pointed out that other bits should be preserved too. > So I make the BMCR_ISOLATE and BMCR_PDOWN as well. > > Signed-off-by: Weidong Wang Applied, thank you.