Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752766AbcDPBA5 (ORCPT ); Fri, 15 Apr 2016 21:00:57 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:42698 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750779AbcDPBA4 (ORCPT ); Fri, 15 Apr 2016 21:00:56 -0400 Date: Fri, 15 Apr 2016 18:00:53 -0700 From: Stephen Boyd To: Stefan Agner Cc: shawnguo@kernel.org, kernel@pengutronix.de, mturquette@baylibre.com, linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] clk: imx: do not sleep if IRQ's are still disabled Message-ID: <20160416010052.GR26353@codeaurora.org> References: <1454107764-19876-1-git-send-email-stefan@agner.ch> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1454107764-19876-1-git-send-email-stefan@agner.ch> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 631 Lines: 18 On 01/29, Stefan Agner wrote: > If a clock gets enabled early during boot time, it can lead to a PLL > startup. The wait_lock function makes sure that the PLL is really > stareted up before it gets used. However, the function sleeps which > leads to scheduling and an error: > bad: scheduling from the idle thread! > ... > > Use udelay in case IRQ's are still disabled. > > Signed-off-by: Stefan Agner This is really old. Shawn, are you picking these up? I'm removing these from my queue for now. -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project