Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751300AbcDPLEg (ORCPT ); Sat, 16 Apr 2016 07:04:36 -0400 Received: from szxga01-in.huawei.com ([58.251.152.64]:15856 "EHLO szxga01-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751213AbcDPLEf (ORCPT ); Sat, 16 Apr 2016 07:04:35 -0400 From: Gabriele Paoloni To: , CC: , , , , Subject: [PATCH v2] PCI: Designware: remove wrong RC memory base/limit configuration Date: Sat, 16 Apr 2016 12:03:39 +0100 Message-ID: <1460804619-2972-1-git-send-email-gabriele.paoloni@huawei.com> X-Mailer: git-send-email 2.7.1.windows.1 MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.47.90.94] X-CFilter-Loop: Reflected X-Mirapoint-Virus-RAPID-Raw: score=unknown(0), refid=str=0001.0A020206.57121C28.008F,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0, ip=0.0.0.0, so=2013-06-18 04:22:30, dmn=2013-03-21 17:37:32 X-Mirapoint-Loop-Id: 8ab6d6f0209a1707a8ed71ab673220bc Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1540 Lines: 48 Currently dw_pcie_setup_rc configures memory base and memory limit in the type1 configuration header for the root complex. In doing so it uses the cpu address (pp->mem_base) rather than the bus address (pp->mem_bus_addr): this is wrong and it is useless since the configuration is overwritten later on when pci_bus_assign_resources() is called. Therefore this patch just removes this configuration from dw_pcie_setup_rc. Signed-off-by: Gabriele Paoloni --- v1 -> v2 : removed unused variables in dw_pcie_setup_rc() --- drivers/pci/host/pcie-designware.c | 8 -------- 1 file changed, 8 deletions(-) diff --git a/drivers/pci/host/pcie-designware.c b/drivers/pci/host/pcie-designware.c index a4cccd3..e3cb1f9 100644 --- a/drivers/pci/host/pcie-designware.c +++ b/drivers/pci/host/pcie-designware.c @@ -728,8 +728,6 @@ static struct pci_ops dw_pcie_ops = { void dw_pcie_setup_rc(struct pcie_port *pp) { u32 val; - u32 membase; - u32 memlimit; /* set the number of lanes */ dw_pcie_readl_rc(pp, PCIE_PORT_LINK_CONTROL, &val); @@ -788,12 +786,6 @@ void dw_pcie_setup_rc(struct pcie_port *pp) val |= 0x00010100; dw_pcie_writel_rc(pp, val, PCI_PRIMARY_BUS); - /* setup memory base, memory limit */ - membase = ((u32)pp->mem_base & 0xfff00000) >> 16; - memlimit = (pp->mem_size + (u32)pp->mem_base) & 0xfff00000; - val = memlimit | membase; - dw_pcie_writel_rc(pp, val, PCI_MEMORY_BASE); - /* setup command register */ dw_pcie_readl_rc(pp, PCI_COMMAND, &val); val &= 0xffff0000; -- 2.1.4