Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751611AbcDPRzw (ORCPT ); Sat, 16 Apr 2016 13:55:52 -0400 Received: from smtp2.provo.novell.com ([137.65.250.81]:41879 "EHLO smtp2.provo.novell.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751310AbcDPRzv (ORCPT ); Sat, 16 Apr 2016 13:55:51 -0400 From: Davidlohr Bueso To: bart.vanassche@sandisk.com Cc: dave@stgolabs.net, linux-kernel@vger.kernel.org, Davidlohr Bueso Subject: [PATCH] irq_poll: Remove redundant barrier when using clear_bit_unlock() Date: Sat, 16 Apr 2016 10:55:36 -0700 Message-Id: <1460829336-6146-1-git-send-email-dave@stgolabs.net> X-Mailer: git-send-email 2.8.1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 845 Lines: 30 ... as the call obviously already implies unlock/RC semantics, therefore lets get rid of the superfluous smp_mb calls. Signed-off-by: Davidlohr Bueso --- lib/irq_poll.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/lib/irq_poll.c b/lib/irq_poll.c index 836f7db4e548..2a6ae2720ccb 100644 --- a/lib/irq_poll.c +++ b/lib/irq_poll.c @@ -50,7 +50,6 @@ EXPORT_SYMBOL(irq_poll_sched); static void __irq_poll_complete(struct irq_poll *iop) { list_del(&iop->list); - smp_mb__before_atomic(); clear_bit_unlock(IRQ_POLL_F_SCHED, &iop->state); } @@ -161,7 +160,6 @@ EXPORT_SYMBOL(irq_poll_disable); void irq_poll_enable(struct irq_poll *iop) { BUG_ON(!test_bit(IRQ_POLL_F_SCHED, &iop->state)); - smp_mb__before_atomic(); clear_bit_unlock(IRQ_POLL_F_SCHED, &iop->state); } EXPORT_SYMBOL(irq_poll_enable); -- 2.8.1