Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1751788AbcDPTE0 (ORCPT <rfc822;w@1wt.eu>);
	Sat, 16 Apr 2016 15:04:26 -0400
Received: from smtprelay0162.hostedemail.com ([216.40.44.162]:60448 "EHLO
	smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL)
	by vger.kernel.org with ESMTP id S1751426AbcDPTEZ (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Sat, 16 Apr 2016 15:04:25 -0400
X-Session-Marker: 6A6F6540706572636865732E636F6D
X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::,RULES_HIT:41:355:379:541:800:960:973:982:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:2197:2199:2393:2559:2562:2828:3138:3139:3140:3141:3142:3352:3653:3866:3872:3874:4321:5007:8957:10004:10226:10400:10848:11026:11473:11658:11783:11914:12043:12291:12296:12438:12517:12519:12555:13069:13311:13357:13439:13894:14181:14394:14659:14721:21080:21221:30054:30070,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:2,LUA_SUMMARY:none
X-HE-Tag: cow21_436ce54f77b36
X-Filterd-Recvd-Size: 2229
Message-ID: <1460833453.19090.79.camel@perches.com>
Subject: [PATCH] checkpatch: Whine about ACCESS_ONCE
From: Joe Perches <joe@perches.com>
To: Andrew Morton <akpm@linux-foundation.org>,
        Andy Whitcroft <apw@shadowen.org>
Cc: linux-kernel@vger.kernel.org, Davidlohr Bueso <dbueso@suse.de>,
        Davidlohr Bueso <dave@stgolabs.net>
Date: Sat, 16 Apr 2016 12:04:13 -0700
In-Reply-To: <1460828078-5224-1-git-send-email-dave@stgolabs.net>
References: <1460828078-5224-1-git-send-email-dave@stgolabs.net>
Content-Type: text/plain; charset="ISO-8859-1"
X-Mailer: Evolution 3.18.5.2-0ubuntu1 
Mime-Version: 1.0
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1347
Lines: 43

Add a test for use of ACCESS_ONCE that could be written using
READ_ONCE or WRITE_ONCE.

--fix it too if desired.

Signed-off-by: Joe Perches <joe@perches.com>
---
?scripts/checkpatch.pl | 22 ++++++++++++++++++++++
?1 file changed, 22 insertions(+)

diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index e3d9c34..5e5d2a4 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -5837,6 +5837,28 @@ sub process {
?			}
?		}
?
+# whine about ACCESS_ONCE
+		if ($^V && $^V ge 5.10.0 &&
+		????$line =~ /\bACCESS_ONCE\s*$balanced_parens\s*(=(?!=))?\s*($FuncArg)?/) {
+			my $par = $1;
+			my $eq = $2;
+			my $fun = $3;
+			$par =~ s/^\(\s*(.*)\s*\)$/$1/;
+			if (defined($eq)) {
+				if (WARN("PREFER_WRITE_ONCE",
+					?"Prefer WRITE_ONCE(<FOO>, <BAR>) over ACCESS_ONCE(<FOO>) = <BAR>\n" . $herecurr) &&
+				????$fix) {
+					$fixed[$fixlinenr] =~ s/\bACCESS_ONCE\s*\(\s*\Q$par\E\s*\)\s*$eq\s*\Q$fun\E/WRITE_ONCE($par, $fun)/;
+				}
+			} else {
+				if (WARN("PREFER_READ_ONCE",
+					?"Prefer READ_ONCE(<FOO>) over ACCESS_ONCE(<FOO>)\n" . $herecurr) &&
+				????$fix) {
+					$fixed[$fixlinenr] =~ s/\bACCESS_ONCE\s*\(\s*\Q$par\E\s*\)/READ_ONCE($par)/;
+				}
+			}
+		}
+
?# check for lockdep_set_novalidate_class
?		if ($line =~ /^.\s*lockdep_set_novalidate_class\s*\(/ ||
?		????$line =~ /__lockdep_no_validate__\s*\)/ ) {