Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751829AbcDPTIH (ORCPT ); Sat, 16 Apr 2016 15:08:07 -0400 Received: from mail-wm0-f43.google.com ([74.125.82.43]:38554 "EHLO mail-wm0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751426AbcDPTIF (ORCPT ); Sat, 16 Apr 2016 15:08:05 -0400 Subject: Re: [PATCH 1/2] clocksource: sp804: Add support for OX810SE 24bit timer width To: Mathieu Poirier References: <1459520559-13110-1-git-send-email-narmstrong@baylibre.com> <1459520559-13110-2-git-send-email-narmstrong@baylibre.com> Cc: "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , Daniel Lezcano , tglx@linutronix.de, Russell King , Sudeep Holla From: Neil Armstrong Organization: Baylibre Message-ID: <57128D8C.4000801@baylibre.com> Date: Sat, 16 Apr 2016 21:07:56 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1089 Lines: 28 On 04/01/2016 05:33 PM, Mathieu Poirier wrote: > On 1 April 2016 at 08:22, Neil Armstrong wrote: Hi Matthieu, Thanks for the review. >> + /* OX810SE Uses a special 24bit width */ >> + if (of_device_is_compatible(np, "oxsemi,ox810se-rps-timer")) >> + width = 24; > > Wouldn't it be better to add a new optional property for this? If the > property is not specified then we default to a width of 32. Otherwise > the new width is configured. That way we don't have to add a new > compatible string every time (however often) a special width is > encountered. As explained by Rob Herring, this HW is compatible with SP804 but is /not/ an IP from ARM and has been customized to support 24bit. Having a DT property for this width is not wanted actually since it makes no sense for the original SP804 IP, so it should be handled per vendor. > > Otherwise I think the code facelift looks good, > Mathieu Is there any other blocking points ? The point to have a change on sp804 is to economize a new very similar driver for oxnas. Neil