Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752000AbcDPT0v (ORCPT ); Sat, 16 Apr 2016 15:26:51 -0400 Received: from saturn.retrosnub.co.uk ([178.18.118.26]:49676 "EHLO saturn.retrosnub.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751574AbcDPT0u (ORCPT ); Sat, 16 Apr 2016 15:26:50 -0400 Subject: Re: [PATCH 2/2] iio: adc: set INPUT_PROP_DIRECT To: Ksenija Stanojevic , dmitry.torokhov@gmail.com References: <7838d255676f6f778bf9710454f632cd68a35185.1460316098.git.ksenija.stanojevic@gmail.com> Cc: knaack.h@gmx.de, lars@metafoo.de, pmeerw@pmeerw.net, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Torokhov From: Jonathan Cameron Message-ID: <571291F8.1010804@kernel.org> Date: Sat, 16 Apr 2016 20:26:48 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.7.1 MIME-Version: 1.0 In-Reply-To: <7838d255676f6f778bf9710454f632cd68a35185.1460316098.git.ksenija.stanojevic@gmail.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 986 Lines: 23 On 10/04/16 20:22, Ksenija Stanojevic wrote: > Set INPUT_PROP_DIRECT to indicate that it is a touchscreen on the > device to help userspace classify it. > > Signed-off-by: Ksenija Stanojevic Sounds correct to me. Dmitry? > --- > drivers/iio/adc/mxs-lradc.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/iio/adc/mxs-lradc.c b/drivers/iio/adc/mxs-lradc.c > index 07287af..e4c4c5c 100644 > --- a/drivers/iio/adc/mxs-lradc.c > +++ b/drivers/iio/adc/mxs-lradc.c > @@ -1127,6 +1127,7 @@ static int mxs_lradc_ts_register(struct mxs_lradc *lradc) > __set_bit(EV_ABS, input->evbit); > __set_bit(EV_KEY, input->evbit); > __set_bit(BTN_TOUCH, input->keybit); > + __set_bit(INPUT_PROP_DIRECT, input->propbit); > input_set_abs_params(input, ABS_X, 0, LRADC_SINGLE_SAMPLE_MASK, 0, 0); > input_set_abs_params(input, ABS_Y, 0, LRADC_SINGLE_SAMPLE_MASK, 0, 0); > input_set_abs_params(input, ABS_PRESSURE, 0, LRADC_SINGLE_SAMPLE_MASK, >