Message-ID: <1460836099.19090.82.camel@perches.com>
Subject: Re: [PATCH] checkpatch: Whine about ACCESS_ONCE
From: Joe Perches <joe@perches.com>
To: Andrew Morton <akpm@linux-foundation.org>,
        Andy Whitcroft <apw@shadowen.org>, Julia Lawall <julia.lawall@lip6.fr>
Cc: linux-kernel@vger.kernel.org, Davidlohr Bueso <dbueso@suse.de>,
        Davidlohr Bueso <dave@stgolabs.net>
Date: Sat, 16 Apr 2016 12:48:19 -0700
In-Reply-To: <1460833453.19090.79.camel@perches.com>
References: <1460828078-5224-1-git-send-email-dave@stgolabs.net>
	 <1460833453.19090.79.camel@perches.com>
Content-Type: text/plain; charset="ISO-8859-1"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 408
Lines: 24

On Sat, 2016-04-16 at 12:04 -0700, Joe Perches wrote:
> Add a test for use of ACCESS_ONCE that could be written using
> READ_ONCE or WRITE_ONCE.
> 
> --fix it too if desired.

And here's a simple coccinelle script that does a
rather better job:

$ cat access_once.cocci
@@
expression e1;
expression e2;
@@

-	ACCESS_ONCE(e1) = e2
+	WRITE_ONCE(e1, e2)

@@
expression e1;
@@

-	ACCESS_ONCE(e1)
+	READ_ONCE(e1)