Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752436AbcDQBvH (ORCPT ); Sat, 16 Apr 2016 21:51:07 -0400 Received: from host.buserror.net ([209.198.135.123]:38696 "EHLO host.buserror.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752156AbcDQBvF (ORCPT ); Sat, 16 Apr 2016 21:51:05 -0400 Message-ID: <1460857857.32510.176.camel@buserror.net> From: Scott Wood To: Alessio Igor Bogani , Kumar Gala , linuxppc-dev@lists.ozlabs.org Cc: LKML Date: Sat, 16 Apr 2016 20:50:57 -0500 In-Reply-To: References: <1459950325-10327-1-git-send-email-alessio.bogani@elettra.eu> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.16.5-1ubuntu3.1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-SA-Exim-Connect-IP: 75.72.173.242 X-SA-Exim-Mail-From: oss@buserror.net X-Spam-Report: * -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP * -15 BAYES_00 BODY: Bayes spam probability is 0 to 1% * [score: 0.0000] Subject: Re: [RFC PATCH 1/1] powerpc/fsl: Fix build of the dtb embedded kernel images X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:57:07 +0000) X-SA-Exim-Scanned: Yes (on host.buserror.net) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1741 Lines: 48 On Fri, 2016-04-15 at 10:27 +0200, Alessio Igor Bogani wrote: > Hi, > > On 6 April 2016 at 15:45, Alessio Igor Bogani > wrote: > > The commit dc37374 move a lot of device tree files into fsl directory > > fixing Makefile for cuImage target only. Unfortunately there are others > > target which require to embebbed device tree into the kernel image > > (i.e. dtbImage.%). So use a more generic approach. > > > > Signed-off-by: Alessio Igor Bogani > > --- > > arch/powerpc/boot/Makefile | 6 +++--- > > 1 file changed, 3 insertions(+), 3 deletions(-) > > > > diff --git a/arch/powerpc/boot/Makefile b/arch/powerpc/boot/Makefile > > index 6116510..8fe78a3 100644 > > --- a/arch/powerpc/boot/Makefile > > +++ b/arch/powerpc/boot/Makefile > > @@ -362,9 +362,6 @@ $(obj)/cuImage.initrd.%: vmlinux $(obj)/%.dtb > > $(wrapperbits) > > $(obj)/cuImage.%: vmlinux $(obj)/%.dtb $(wrapperbits) > > $(call if_changed,wrap,cuboot-$*,,$(obj)/$*.dtb) > > > > -$(obj)/cuImage.%: vmlinux $(obj)/fsl/%.dtb $(wrapperbits) > > - $(call if_changed,wrap,cuboot-$*,,$(obj)/fsl/$*.dtb) > > - > > $(obj)/simpleImage.initrd.%: vmlinux $(obj)/%.dtb $(wrapperbits) > > $(call if_changed,wrap,simpleboot > > -$*,,$(obj)/$*.dtb,$(obj)/ramdisk.image.gz) > > > > @@ -381,6 +378,9 @@ $(obj)/treeImage.%: vmlinux $(obj)/%.dtb > > $(wrapperbits) > > $(obj)/%.dtb: $(src)/dts/%.dts FORCE > > $(call if_changed_dep,dtc) > > > > +$(obj)/%.dtb: $(src)/dts/fsl/%.dts FORCE > > + $(call if_changed_dep,dtc) > > + > > # If there isn't a platform selected then just strip the vmlinux. > > ifeq (,$(image-y)) > > image-y := vmlinux.strip > > Any comments? Looks OK to me. -Scott