Date: Sun, 17 Apr 2016 13:50:37 +0200
From: Jiri Olsa <jolsa@redhat.com>
To: Wang Nan <wangnan0@huawei.com>
Cc: acme@kernel.org, linux-kernel@vger.kernel.org, pi3orama@163.com,
        Adrian Hunter <adrian.hunter@intel.com>, He Kuang <hekuang@huawei.com>,
        Jiri Olsa <jolsa@kernel.org>, Masami Hiramatsu <mhiramat@kernel.org>,
        Namhyung Kim <namhyung@kernel.org>, Zefan Li <lizefan@huawei.com>,
        Arnaldo Carvalho de Melo <acme@redhat.com>
Subject: Re: [PATCH v3 1/6] perf tools: Derive trigger class from
 auxtrace_snapshot
Message-ID: <20160417115037.GA31336@krava.brq.redhat.com>
References: <1460744420-175165-1-git-send-email-wangnan0@huawei.com>
 <1460744420-175165-2-git-send-email-wangnan0@huawei.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1460744420-175165-2-git-send-email-wangnan0@huawei.com>
User-Agent: Mutt/1.5.24 (2015-08-30)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 770
Lines: 19

On Fri, Apr 15, 2016 at 06:20:15PM +0000, Wang Nan wrote:
> Create a new class named 'trigger' to model the state of a trigger and
> implement auxtrace_snapshot with it.
> 
> auxtrace_record__snapshot_started and auxtrace_snapshot_err are absorbed.
> 
> 'trigger' defines 4 state transitioning functions ('on', 'released',
> 'toggle' and 'colddown') and 2 state query function ('is_released') and
> ('is_toggled'). The state 'ON' and 'OFF' take higher priority than
> 'RELEASED' and 'TOGGLED'.  A trigger must be 'on' before 'enable' and
> 'disable' take effect. A trigger can be colddown after being triggered.

what's the COLDDOWN state for?

could you please document all the transitions of this state machine
in the change log and the trigger.h file?

thanks,
jirka