Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753153AbcDQNcv (ORCPT ); Sun, 17 Apr 2016 09:32:51 -0400 Received: from mail-lf0-f68.google.com ([209.85.215.68]:34795 "EHLO mail-lf0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751673AbcDQNct (ORCPT ); Sun, 17 Apr 2016 09:32:49 -0400 Date: Sun, 17 Apr 2016 15:32:40 +0200 From: Krzysztof Kozlowski To: Javier Martinez Canillas Cc: linux-kernel@vger.kernel.org, Anand Moon , Kukjin Kim , linux-samsung-soc@vger.kernel.org, Wolfram Sang , Krzysztof Kozlowski , linux-i2c@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v2 1/2] i2c: exynos5: Check clk_prepare_enable() return value Message-ID: <20160417133240.GB3620@kozik-lap> References: <1460855693-28225-1-git-send-email-javier@osg.samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1460855693-28225-1-git-send-email-javier@osg.samsung.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 509 Lines: 20 On Sat, Apr 16, 2016 at 09:14:52PM -0400, Javier Martinez Canillas wrote: > The clk_prepare_enable() function can fail so check the return value > and propagate the error to the caller in case of a failure. > > Signed-off-by: Javier Martinez Canillas > --- > > Changes in v2: None > > drivers/i2c/busses/i2c-exynos5.c | 12 +++++++++--- > 1 file changed, 9 insertions(+), 3 deletions(-) > Hi, Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof