Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751888AbcDRB6i (ORCPT ); Sun, 17 Apr 2016 21:58:38 -0400 Received: from mail.kernel.org ([198.145.29.136]:49030 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751307AbcDRB6h (ORCPT ); Sun, 17 Apr 2016 21:58:37 -0400 Date: Mon, 18 Apr 2016 09:58:06 +0800 From: Shawn Guo To: Stephen Boyd Cc: Stefan Agner , kernel@pengutronix.de, mturquette@baylibre.com, linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] clk: imx: do not sleep if IRQ's are still disabled Message-ID: <20160418015806.GR28903@tiger> References: <1454107764-19876-1-git-send-email-stefan@agner.ch> <20160416010052.GR26353@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160416010052.GR26353@codeaurora.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 642 Lines: 19 On Fri, Apr 15, 2016 at 06:00:53PM -0700, Stephen Boyd wrote: > On 01/29, Stefan Agner wrote: > > If a clock gets enabled early during boot time, it can lead to a PLL > > startup. The wait_lock function makes sure that the PLL is really > > stareted up before it gets used. However, the function sleeps which > > leads to scheduling and an error: > > bad: scheduling from the idle thread! > > ... > > > > Use udelay in case IRQ's are still disabled. > > > > Signed-off-by: Stefan Agner > > This is really old. Shawn, are you picking these up? I'm removing > these from my queue for now. Yes, I'm picking them up. Shawn