Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752127AbcDRDlf (ORCPT ); Sun, 17 Apr 2016 23:41:35 -0400 Received: from mail.kernel.org ([198.145.29.136]:51384 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752739AbcDRCak (ORCPT ); Sun, 17 Apr 2016 22:30:40 -0400 MIME-Version: 1.0 In-Reply-To: <20160418020252.GS28903@tiger> References: <1459544080-28598-1-git-send-email-stuart.yoder@nxp.com> <20160413055019.GK28903@tiger> <20160418020252.GS28903@tiger> Date: Mon, 18 Apr 2016 10:30:36 +0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 2/2] arm64: dts: ls2080a: fsl-mc dt node updates From: Shawn Guo To: Stuart Yoder Cc: "mark.rutland@arm.com" , "devicetree@vger.kernel.org" , "german.rivera@freescale.com" , "linux-kernel@vger.kernel.org" , Yang-Leo Li , "robh+dt@kernel.org" , "linux-arm-kernel@lists.infradead.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1940 Lines: 43 On Mon, Apr 18, 2016 at 10:02 AM, Shawn Guo wrote: > On Wed, Apr 13, 2016 at 08:39:32PM +0000, Stuart Yoder wrote: >> > > @@ -265,6 +265,93 @@ >> > > compatible = "fsl,qoriq-mc"; >> > > reg = <0x00000008 0x0c000000 0 0x40>, /* MC portal base */ >> > > <0x00000000 0x08340000 0 0x40000>; /* MC control reg */ >> > > + msi-parent = <&its>; >> > > + #address-cells = <3>; >> > > + #size-cells = <1>; >> > > + >> > > + /* >> > > + * Region type 0x0 - MC portals >> > > + * Region type 0x1 - QBMAN portals >> > > + */ >> > > + ranges = <0x0 0x0 0x0 0x8 0x0c000000 0x4000000 >> > > + 0x1 0x0 0x0 0x8 0x18000000 0x8000000>; >> > > + >> > > + /* >> > > + * Define the maximum number of MACs present on the SoC. >> > > + * They won't necessarily be all probed, since the >> > > + * Data Path Layout file and the MC firmware can put >> > > + * fewer actual DPMAC objects on the MC bus. >> > > + */ >> > > + dpmacs { >> > > + #address-cells = <1>; >> > > + #size-cells = <0>; >> > > + >> > > + dpmac1: dpmac@1 { >> > > + compatible = "fsl,qoriq-mc-dpmac"; >> > >> > I did not see how this compatible is used by kernel driver. >> >> There is no driver yet, but it will be coming soon. But, does >> it matter? Device trees should be describing hardware >> without regards to some specific kernel use of a node or >> property. > > We need to at least have the bindings documented before we can accept it > in dts files. Ah, sorry. Missed that the bindings are added by patch 1/2. Shawn