Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751600AbcDRESL (ORCPT ); Mon, 18 Apr 2016 00:18:11 -0400 Received: from mail-qg0-f66.google.com ([209.85.192.66]:33430 "EHLO mail-qg0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751278AbcDRESJ (ORCPT ); Mon, 18 Apr 2016 00:18:09 -0400 MIME-Version: 1.0 In-Reply-To: <1460839171-1252854-1-git-send-email-arnd@arndb.de> References: <1460839171-1252854-1-git-send-email-arnd@arndb.de> Date: Mon, 18 Apr 2016 09:48:07 +0530 Message-ID: Subject: Re: [PATCH] spi: cadence: mark pm functions __maybe_unused From: Shubhrajyoti Datta To: Arnd Bergmann Cc: Mark Brown , Shubhrajyoti Datta , Moritz Fischer , Geliang Tang , linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 755 Lines: 19 On Sun, Apr 17, 2016 at 2:09 AM, Arnd Bergmann wrote: > The newly added runtime PM support for the cadence spi driver > causes harmless warnings when PM is disabled: > > drivers/spi/spi-cadence.c:681:12: warning: 'cnds_runtime_suspend' defined but not used > drivers/spi/spi-cadence.c:652:12: warning: 'cnds_runtime_resume' defined but not used > > This adds __maybe_unused annotations to the respective functions > to shut up the warnings, while leaving the code in place for > compile testing and avoiding ugly #ifdefs. Thanks for the patch. Feel free to add my ack. Acked-by: Shubhrajyoti Datta > > Signed-off-by: Arnd Bergmann > Fixes: d36ccd9f7ea4 ("spi: cadence: Runtime pm adaptation") > ---