Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751955AbcDRGCz (ORCPT ); Mon, 18 Apr 2016 02:02:55 -0400 Received: from mail-yw0-f172.google.com ([209.85.161.172]:33001 "EHLO mail-yw0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751695AbcDRGCw (ORCPT ); Mon, 18 Apr 2016 02:02:52 -0400 MIME-Version: 1.0 In-Reply-To: <20160418054511.GA17368@gondor.apana.org.au> References: <20160415134849.GA32694@gondor.apana.org.au> <20160418054511.GA17368@gondor.apana.org.au> Date: Mon, 18 Apr 2016 14:02:51 +0800 Message-ID: Subject: Re: [PATCH v2 0/4] Introduce bulk mode for crypto engine framework From: Baolin Wang To: Herbert Xu Cc: David Miller , Alasdair G Kergon , Mike Snitzer , Jens Axboe , dm-devel@redhat.com, Andrew Morton , david.s.gordon@intel.com, Tom Lendacky , Robert Jarzmik , Masahiro Yamada , smueller@chronox.de, tadeusz.struk@intel.com, Masanari Iida , shli@kernel.org, Mark Brown , Linus Walleij , Arnd Bergmann , LKML , linux-crypto@vger.kernel.org, linux-raid@vger.kernel.org Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1355 Lines: 36 On 18 April 2016 at 13:45, Herbert Xu wrote: > On Mon, Apr 18, 2016 at 01:31:09PM +0800, Baolin Wang wrote: >> >> We've tried to do this in dm-crypt, but it failed. >> The dm-crypt maintainer explained to me that I should optimize the >> driver, not add strange hw-dependent crypto modes to dm-crypt, this is >> not the first crypto accelerator that is just not suited for this kind >> of use. >> He thought if it can process batch of chunks of data each with own IV, >> then it can work with dm-crypt, but he thought such optimized code >> should be inside crypto API, not in dmcrypt. > > That's a completely bogus argument. The user always has more > information available than the underlying API. So it is totally > stupid to have the API try to extract information that the user > could have provided in the first place. If the crypto hardware engine can support bulk data encryption/decryption, so the engine driver can select bulk mode to handle the requests. I think it is a totally driver things, not in dmcrypt. The dmcrypt can not get the hardware engine's attributes. > > I'm not taking this patch-set. > > Cheers, > -- > Email: Herbert Xu > Home Page: http://gondor.apana.org.au/~herbert/ > PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- Baolin.wang Best Regards