Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752215AbcDRGdv (ORCPT ); Mon, 18 Apr 2016 02:33:51 -0400 Received: from mail1.asahi-net.or.jp ([202.224.39.197]:15022 "EHLO mail1.asahi-net.or.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752037AbcDRGdt (ORCPT ); Mon, 18 Apr 2016 02:33:49 -0400 Date: Mon, 18 Apr 2016 15:33:46 +0900 Message-ID: <8760vfcto5.wl-ysato@users.sourceforge.jp> From: Yoshinori Sato To: Tejun Heo Cc: Bartlomiej Zolnierkiewicz , linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] pata_artop: Use ioread8. In-Reply-To: <20160414154517.GD12583@htj.duckdns.org> References: <1460618763-1712-1-git-send-email-ysato@users.sourceforge.jp> <20160414154517.GD12583@htj.duckdns.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL/10.8 EasyPG/1.0.0 Emacs/24.5 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1035 Lines: 41 On Fri, 15 Apr 2016 00:45:17 +0900, Tejun Heo wrote: > > Hello, > > On Thu, Apr 14, 2016 at 04:26:03PM +0900, Yoshinori Sato wrote: > > Support for non x86 targets. > > Being a bit more detailed would be nice. > > > Signed-off-by: Yoshinori Sato > > --- > > drivers/ata/pata_artop.c | 16 +++++++++++++--- > > 1 file changed, 13 insertions(+), 3 deletions(-) > > > > diff --git a/drivers/ata/pata_artop.c b/drivers/ata/pata_artop.c > > index 96c05c9..3731dea 100644 > > --- a/drivers/ata/pata_artop.c > > +++ b/drivers/ata/pata_artop.c > > @@ -340,6 +340,18 @@ static void atp8xx_fixup(struct pci_dev *pdev) > > } > > } > > > > +static int is_fast(struct pci_dev *pdev) > > Can you please make the name a bit more descriptive? > > Thanks. OK. I tried SuperH and ATP-865 system. This CPU maps PCI IO space in memory window. An address translation is needed by this CPU. But inb not address translation. So can't access register. > -- > tejun -- Yoshinori Sato