Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751986AbcDRHEy (ORCPT ); Mon, 18 Apr 2016 03:04:54 -0400 Received: from helcar.hengli.com.au ([209.40.204.226]:59859 "EHLO helcar.hengli.com.au" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751451AbcDRHEw (ORCPT ); Mon, 18 Apr 2016 03:04:52 -0400 Date: Mon, 18 Apr 2016 15:04:07 +0800 From: Herbert Xu To: Baolin Wang Cc: David Miller , Alasdair G Kergon , Mike Snitzer , Jens Axboe , dm-devel@redhat.com, Andrew Morton , david.s.gordon@intel.com, Tom Lendacky , Robert Jarzmik , Masahiro Yamada , smueller@chronox.de, tadeusz.struk@intel.com, Masanari Iida , shli@kernel.org, Mark Brown , Linus Walleij , Arnd Bergmann , LKML , linux-crypto@vger.kernel.org, linux-raid@vger.kernel.org Subject: Re: [PATCH v2 0/4] Introduce bulk mode for crypto engine framework Message-ID: <20160418070407.GA17760@gondor.apana.org.au> References: <20160415134849.GA32694@gondor.apana.org.au> <20160418054511.GA17368@gondor.apana.org.au> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 608 Lines: 15 On Mon, Apr 18, 2016 at 02:02:51PM +0800, Baolin Wang wrote: > > If the crypto hardware engine can support bulk data > encryption/decryption, so the engine driver can select bulk mode to > handle the requests. I think it is a totally driver things, not in > dmcrypt. The dmcrypt can not get the hardware engine's attributes. It has nothing to do with the hardware attributes. dm-crypt should be sending maximal requests in the first place. Cheers, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt