Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751957AbcDRHnc (ORCPT ); Mon, 18 Apr 2016 03:43:32 -0400 Received: from mailout4.w1.samsung.com ([210.118.77.14]:28954 "EHLO mailout4.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751454AbcDRHna (ORCPT ); Mon, 18 Apr 2016 03:43:30 -0400 X-AuditID: cbfec7f4-f796c6d000001486-0f-5714901fb8a0 From: Krzysztof Kozlowski To: Sangbeom Kim , Krzysztof Kozlowski , Liam Girdwood , Mark Brown , linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org Cc: Bartlomiej Zolnierkiewicz Subject: [PATCH] regulator: s2mps11: Remove unused set_voltage_time_sel Date: Mon, 18 Apr 2016 09:42:58 +0200 Message-id: <1460965378-5256-1-git-send-email-k.kozlowski@samsung.com> X-Mailer: git-send-email 1.9.1 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrGJMWRmVeSWpSXmKPExsVy+t/xK7ryE0TCDbasELTYOGM9q8XUh0/Y LF6/MLT4dqWDyeLyrjlsFjPO72OyuLjiC5MDu8fOWXfZPTat6mTz6NuyitHj8ya5AJYoLpuU 1JzMstQifbsEroy1N7+xFDwUqFi7+CtbA2MDXxcjJ4eEgInExA0fmSFsMYkL99azdTFycQgJ LGWU+Lx1IitIQkigkUnizKUyEJtNwFhi8/IlYEUiAo8YJQ5u+s8GkmAWsJDYunU1O4gtLOAu seDCTBYQm0VAVWLlyV1MIDavgJvEjulfWSC2yUmcPDaZdQIj9wJGhlWMoqmlyQXFSem5hnrF ibnFpXnpesn5uZsYIaHxZQfj4mNWhxgFOBiVeHgjGETChVgTy4orcw8xSnAwK4nw5rQDhXhT EiurUovy44tKc1KLDzFKc7AoifPO3fU+REggPbEkNTs1tSC1CCbLxMEp1cA46eQz/rCFZ8sm CwscXer+7sIzyXsurxdLpB11SesseGP7ZsolCwvxL97pyw4t+D6JM9ZKeEFMZL3YualBx82m ijSqOJ05/Um/eHf4xwvidWzRTyZLV4j6esdd29A3I4Qrm/3bj4umRgE+VZfjOa0z2y0/HlWq /LsyZFt6RdxuC+8DFx+UK19SYinOSDTUYi4qTgQACWYIcgkCAAA= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2093 Lines: 50 On S2MPS11 and S2MPS14 devices the default implementation of set_voltage_time_sel() for LDO regulators was not doing anything useful because users did not provide ramp delay in Device Tree so the set_voltage_time_sel() exited with status 0. This could be seen in dmesg, e.g. on Odroid XU4: [ 1.486076] vdd_ldo9: ramp_delay not set [ 1.506875] vddq_mmc2: ramp_delay not set [ 1.523766] vdd_ldo15: ramp_delay not set [ 1.544702] vdd_sd: ramp_delay not set The datasheet for these devices is inconsistent and does not specify unambiguously the value of ramp delay for LDO. It mentions 30 mV/us in one timing diagram but then omits it completely in LDO regulator characteristics table (it is specified for bucks). To make more confusion, the vendor kernel for Galaxy S5 and Odroid XU3 uses sometimes value of 12 mV/us. Overall, since the ramp delay is not currently provided by DT and it is unclear what is the correct value anyway, the safest choice seems to be to remove the implementation of set_voltage_time_sel() for S2MPS11 and S2MPS14 LDOs thus getting rid of the warning. Signed-off-by: Krzysztof Kozlowski --- drivers/regulator/s2mps11.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/regulator/s2mps11.c b/drivers/regulator/s2mps11.c index 64a262f10845..437b1b3b26c9 100644 --- a/drivers/regulator/s2mps11.c +++ b/drivers/regulator/s2mps11.c @@ -246,7 +246,6 @@ static struct regulator_ops s2mps11_ldo_ops = { .disable = regulator_disable_regmap, .get_voltage_sel = regulator_get_voltage_sel_regmap, .set_voltage_sel = regulator_set_voltage_sel_regmap, - .set_voltage_time_sel = regulator_set_voltage_time_sel, }; static struct regulator_ops s2mps11_buck_ops = { @@ -606,7 +605,6 @@ static struct regulator_ops s2mps14_reg_ops = { .disable = regulator_disable_regmap, .get_voltage_sel = regulator_get_voltage_sel_regmap, .set_voltage_sel = regulator_set_voltage_sel_regmap, - .set_voltage_time_sel = regulator_set_voltage_time_sel, .set_suspend_disable = s2mps14_regulator_set_suspend_disable, }; -- 1.9.1