Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752023AbcDRJXB (ORCPT ); Mon, 18 Apr 2016 05:23:01 -0400 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:50752 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751748AbcDRJXA (ORCPT ); Mon, 18 Apr 2016 05:23:00 -0400 Date: Mon, 18 Apr 2016 10:22:18 +0100 From: Mark Brown To: Xing Zheng Cc: linux-rockchip@lists.infradead.org, heiko@sntech.de, Adam.Thomson@diasemi.com, sugar.zhang@rock-chips.com, jay.xu@rock-chips.com, Liam Girdwood , Jaroslav Kysela , Takashi Iwai , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Message-ID: <20160418092218.GL3217@sirena.org.uk> References: <1460967452-24574-1-git-send-email-zhengxing@rock-chips.com> <1460967452-24574-2-git-send-email-zhengxing@rock-chips.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="4e5ZDkbgLEOfWmLx" Content-Disposition: inline In-Reply-To: <1460967452-24574-2-git-send-email-zhengxing@rock-chips.com> X-Cookie: Tomorrow, you can be anywhere. User-Agent: Mutt/1.5.24 (2015-08-30) X-SA-Exim-Connect-IP: 2a01:348:6:8808:fab::3 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH 1/3] ASoC: jack: Add a jack detect callback via codec X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1343 Lines: 37 --4e5ZDkbgLEOfWmLx Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Apr 18, 2016 at 04:17:30PM +0800, Xing Zheng wrote: > This patch add a callback when a codec have the jack detect feature. > +void snd_soc_jack_codec_detect(struct snd_soc_codec *codec, > + struct snd_soc_jack *jack) > +{ > + if (codec && codec->driver && codec->driver->detect_jack) > + codec->driver->detect_jack(codec, jack); > +} > +EXPORT_SYMBOL_GPL(snd_soc_jack_codec_detect); I've no idea what this is supposed to do sorry, you need a much better changelog and probably also a restructuring of the code. This says it is adding a callback but it doesn't do that, it adds an export of a function that calls an operation in a driver with no explanation. --4e5ZDkbgLEOfWmLx Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJXFKdJAAoJECTWi3JdVIfQfFsH/0cTD0fCjL8ulsJuFqWvTD47 UCIed86ZfZG+ueP537JrwiNxfWeZhmqpLrfrn2yqazBx0CG236El/OBzIVDQ7RZS i0NberfYQTE2SwXe6KYoouG9i8ygfwJczZwFRSk5+U7l0vVwb+KQaIf66au49SHO Z7EmPZsYidIEpE0RCMtXqS/MrXkK3n4cc6bv0ePH6nNoyoe3A4cS8wxTFUVYENJ2 PMkjR0VNgKPnv+LVIL57RvwoAUIqhIjwsRZrXng6eDY5zpY+I23hgC9laB3bPVzd JFOkHJlZ9eh9NldP120ks4nWIOBdG+pQDIV63TqusRV+fW64bq2nyn0KFaSv+ls= =ALD6 -----END PGP SIGNATURE----- --4e5ZDkbgLEOfWmLx--