Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752893AbcDRLqy (ORCPT ); Mon, 18 Apr 2016 07:46:54 -0400 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:51140 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752114AbcDRLqx (ORCPT ); Mon, 18 Apr 2016 07:46:53 -0400 Date: Mon, 18 Apr 2016 12:46:18 +0100 From: Mark Brown To: Xing Zheng Cc: linux-rockchip@lists.infradead.org, heiko@sntech.de, Adam.Thomson@diasemi.com, sugar.zhang@rock-chips.com, jay.xu@rock-chips.com, Liam Girdwood , Jaroslav Kysela , Takashi Iwai , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, dgreid@chromium.org Message-ID: <20160418114618.GW3217@sirena.org.uk> References: <1460967452-24574-1-git-send-email-zhengxing@rock-chips.com> <1460967452-24574-2-git-send-email-zhengxing@rock-chips.com> <20160418092218.GL3217@sirena.org.uk> <5714AC57.2070901@rock-chips.com> <20160418095302.GN3217@sirena.org.uk> <5714B0D4.7080506@rock-chips.com> <5714B4D0.90406@rock-chips.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="sBvc846/5FzkyDmz" Content-Disposition: inline In-Reply-To: <5714B4D0.90406@rock-chips.com> X-Cookie: Tomorrow, you can be anywhere. User-Agent: Mutt/1.5.24 (2015-08-30) X-SA-Exim-Connect-IP: 2a01:348:6:8808:fab::3 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH 1/3] ASoC: jack: Add a jack detect callback via codec X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1886 Lines: 58 --sBvc846/5FzkyDmz Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Apr 18, 2016 at 06:20:00PM +0800, Xing Zheng wrote: > On 2016=E5=B9=B404=E6=9C=8818=E6=97=A5 18:03, Xing Zheng wrote: > sound { > ...... > simple-audio-card,dai-link@0 { > format =3D "i2s"; > cpu { > sound-dai =3D <&i2s0>; > }; >=20 > codec { > sound-dai =3D <&codec>; >=20 > simple-audio-card,codec-jack =3D > "JACK_HEADSET", > "JACK_BTN_0", > "JACK_BTN_1", > "JACK_BTN_2", > "JACK_BTN_3"; > }; > }; This seems like it's only half the job and worryingly close to Linux internals. In particular the fact that the binding is specific to simple-card and the fact that it's being placed on the CODEC (rather than a separate object that the CODEC references) so that we can't combine multiple devices are both a concern. Dylan Reid did have an earlier go at defining a binding for this: http://thread.gmane.org/gmane.linux.alsa.devel/138906 which went through a couple more iterations but the work on that seemed to die off a bit. --sBvc846/5FzkyDmz Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJXFMkBAAoJECTWi3JdVIfQH0AH/3ypMTUXER81aRHuLarRyLOC 38qbLWrsX5NYWt+JNAynYnJo5xAV2GxW1DLW6reQZT6b+kK7ZrZk9iygXFHWisAZ m/9NwvedmGxgKPdF0bp3bsxHp2YQg9bj+p6c3XLbkr1dIhmP0/M5c/HATbxJZFKh B9GIW0zwBBLm1peEtBdAYKCeklzVczOa4OiCgAdWwJeNWwjCCuzGxwnheiX4i77i sYG6oVPyfLwAR4uGmLGesjYsLMY/dUrWQR5KkskzILgbrrcnE+T6Gogmmk5mrJyw WP6DkYXgrSK1X/spbcmsL195epnCYtxBS9ZJxiE3miZR9DJjWoZh40iYFFmrazk= =J3vv -----END PGP SIGNATURE----- --sBvc846/5FzkyDmz--