Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751756AbcDRMSO (ORCPT ); Mon, 18 Apr 2016 08:18:14 -0400 Received: from mga14.intel.com ([192.55.52.115]:31188 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751342AbcDRMSL convert rfc822-to-8bit (ORCPT ); Mon, 18 Apr 2016 08:18:11 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.24,502,1455004800"; d="scan'208";a="87215247" From: "Tirdea, Irina" To: Jonathan Cameron , Alison Schofield CC: "knaack.h@gmx.de" , "lars@metafoo.de" , "pmeerw@pmeerw.net" , "kgene@kernel.org" , "k.kozlowski@samsung.com" , "linux-iio@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-samsung-soc@vger.kernel.org" , Srinivas Pandruvada Subject: RE: [PATCH v2 1/5] iio: accel: bmc150: use regmap to retrieve struct device Thread-Topic: [PATCH v2 1/5] iio: accel: bmc150: use regmap to retrieve struct device Thread-Index: AQHRk1xO2hVT6McbzUueWCFajwJpkJ+M8ngAgAK+KSA= Date: Mon, 18 Apr 2016 12:18:06 +0000 Deferred-Delivery: Mon, 18 Apr 2016 12:18:00 +0000 Message-ID: <1F3AC3675D538145B1661F571FE1805F2F260D21@irsmsx105.ger.corp.intel.com> References: <57129064.9050508@kernel.org> In-Reply-To: <57129064.9050508@kernel.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiM2Y0NDE0YmEtNWJhMS00NWZlLTlkYTQtNTZkODUzNDFkZGNmIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6Ijl0dEpuU05NTndaVHVUc2Z2MzM2QVlWRkRLZFNNQ1hUY3hmWTFzaVhJNFk9In0= x-ctpclassification: CTP_IC x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1445 Lines: 41 > -----Original Message----- > From: Jonathan Cameron [mailto:jic23@kernel.org] > Sent: 16 April, 2016 22:20 > To: Alison Schofield > Cc: knaack.h@gmx.de; lars@metafoo.de; pmeerw@pmeerw.net; kgene@kernel.org; k.kozlowski@samsung.com; linux- > iio@vger.kernel.org; linux-kernel@vger.kernel.org; linux-arm-kernel@lists.infradead.org; linux-samsung-soc@vger.kernel.org; > Srinivas Pandruvada; Tirdea, Irina > Subject: Re: [PATCH v2 1/5] iio: accel: bmc150: use regmap to retrieve struct device > > On 10/04/16 20:05, Alison Schofield wrote: > > Driver includes struct regmap and struct device in its global data. > > Remove the struct device and use regmap API to retrieve device info. > > > > Patch created using Coccinelle plus manual edits. > > > > Signed-off-by: Alison Schofield > I'm happy with this but please do make sure to cc the maintainer / author > of drivers if possible (often the email addresses are out of date!) > > Srinivas, this is one of yours. Are you happy with this? > I've also cc'd Irina who has worked on this driver recently for any > comments. > Looks good to me. Reviewed-by: Irina Tirdea Alison, I think bmc150_magn driver qualifies for this change as well after Daniel's patches got merged [1]. Thanks, Irina [1] https://lkml.org/lkml/2016/4/15/407 > If no one comments in the meantime I'll probably pick these up sometime > in the next week. > > Jonathan