Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752183AbcDRMfJ (ORCPT ); Mon, 18 Apr 2016 08:35:09 -0400 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:51248 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751283AbcDRMfH (ORCPT ); Mon, 18 Apr 2016 08:35:07 -0400 Date: Mon, 18 Apr 2016 13:34:51 +0100 From: Mark Brown To: Crestez Dan Leonard Cc: Jonathan Cameron , Peter Meerwald-Stadler , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Hartmut Knaack , Lars-Peter Clausen , Daniel Baluta Message-ID: <20160418123451.GB3217@sirena.org.uk> References: <5dbbd82290c575f595ae0907aaf8e03117a6d017.1460045763.git.leonard.crestez@intel.com> <570A513A.4020106@kernel.org> <570BBDFC.6010601@intel.com> <57134AFA.3040406@kernel.org> <20160418103212.GQ3217@sirena.org.uk> <5714CFFA.2080309@intel.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="6FinHCQBQ0zFDOqT" Content-Disposition: inline In-Reply-To: <5714CFFA.2080309@intel.com> X-Cookie: Tomorrow, you can be anywhere. User-Agent: Mutt/1.5.24 (2015-08-30) X-SA-Exim-Connect-IP: 2a01:348:6:8808:fab::3 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH 1/5] max44000: Initial commit X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1368 Lines: 37 --6FinHCQBQ0zFDOqT Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Apr 18, 2016 at 03:15:54PM +0300, Crestez Dan Leonard wrote: > As a further clarification: regmap_write will write to hardware even if > the cache is known to be up-to-date and no matter the regcache_type. Did > I understand this correctly? > I'm basing this on reading the code, it seems to me that map->reg_write > is only avoided on error paths or if map->cache_only is set to true. > This always-write guarantee is not obvious and if it's OK for drivers to > rely on it perhaps it should be explicitly documented on regmap_write. Yes. I have to say that you are the first person I've encountered who has been confused by this, I'm not sure why you'd expect writes to be discarded. --6FinHCQBQ0zFDOqT Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJXFNRoAAoJECTWi3JdVIfQjpcH/1IHJUpHGDM/KGi2ZK8OFZPH eaKM2p85//gT715AgR8tD5WcQNafJs5Cl3fxeZzX/WqPalSjza8aTXdEg+HWr2O0 FpZZpyDc9aDGgzxUs38bOxZes83x/6hxNFIxkDeBDzVZSo6Im1MTaKSiDzmHc6gx uWNeR27UHcrCPjxa8iCx8tRD5o1A/nMO9bf1uLjLai15Vdjfc3Q5tEEWIJvKJ1v9 9y6ZTcd6ojXQC9HUueSPLQYuyHC3F/u66aD2cNNZHiqtO+dZDIuAqwM1PI8uR8BF lrd1UEp/971wIWRlSjiWOvXVpTEAllDmBlbt7vlgdj6IJY1n4jJe8Hz775fds+M= =zrmX -----END PGP SIGNATURE----- --6FinHCQBQ0zFDOqT--