Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752463AbcDRNBk (ORCPT ); Mon, 18 Apr 2016 09:01:40 -0400 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:51306 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751416AbcDRNBj (ORCPT ); Mon, 18 Apr 2016 09:01:39 -0400 Date: Mon, 18 Apr 2016 14:01:26 +0100 From: Mark Brown To: Bhuvanchandra DV Cc: gregkh@linuxfoundation.org, stefan@agner.ch, linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org, Stefan Agner Message-ID: <20160418130126.GC3217@sirena.org.uk> References: <1460978308-8062-1-git-send-email-bhuvanchandra.dv@toradex.com> <1460978308-8062-2-git-send-email-bhuvanchandra.dv@toradex.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="qXCixuLMVvZDruUh" Content-Disposition: inline In-Reply-To: <1460978308-8062-2-git-send-email-bhuvanchandra.dv@toradex.com> X-Cookie: Tomorrow, you can be anywhere. User-Agent: Mutt/1.5.24 (2015-08-30) X-SA-Exim-Connect-IP: 2a01:348:6:8808:fab::3 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [RFC 1/2] spi: spidev: Use 'new_id' sysfs file for enabling spidev X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1467 Lines: 41 --qXCixuLMVvZDruUh Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Apr 18, 2016 at 04:48:27PM +0530, Bhuvanchandra DV wrote: > +++ b/Documentation/ABI/testing/sysfs-bus-spi-spidev > @@ -0,0 +1,8 @@ > +What: /sys/bus/spi/drivers/spidev/new_id > +Date: March 2016 > +Description: > + This allows to load spidev at runtime. new_id file accepts bus > + number and chip select in 'B.C' format. > + e.g. > + To load spidev1.1 at runtime: > + $ echo 1.1 > /sys/bus/spi/drivers/spidev/new_id I would expect a new_id file to allow a new device identifier to be added to a driver at runtime but this isn't doing that, it's specifying by bus and chip select instead which is totally different to how we normally bind SPI devices. That seems likely to cause confusion down the line. I'd expect to be able to supply a DT compatible string or a Linux SPI ID. --qXCixuLMVvZDruUh Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJXFNqlAAoJECTWi3JdVIfQTDMH/2HJIsAShm4GQm+704J27Xou 7aNGkHO0BxrBYPyEYa1nngmC/PnBeDHCuA3qXIKIbaBrUNXBffdVKpanNDrMYo7+ +NlAwbx7+UUypiRc1LciWoRPHD0BJCy15uKtJygPXd3yyC58ulKWnWVFxHqEC6hR xjjYrZlI+7mvc2BO8zHBG2GHuUgjq+I0/yrusCHmPkZSjNDTJWvwZ0Yi9Ixj7hV3 fqWCVlEGIgOqZHtUY+4JrBV5Oj5C8fsDJ60dQDabnwIH8ArH7huONiLtEGtBzYI8 F7fF1eZ0lI3bZzSCeBXpvRF+t7upNADpbgUSD1CjH5bjGxRHnBGk/nRL8dkuApc= =v+f+ -----END PGP SIGNATURE----- --qXCixuLMVvZDruUh--