Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752702AbcDRNGW (ORCPT ); Mon, 18 Apr 2016 09:06:22 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:36640 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752396AbcDRNGU (ORCPT ); Mon, 18 Apr 2016 09:06:20 -0400 MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Mon, 18 Apr 2016 09:06:18 -0400 From: okaya@codeaurora.org To: Christoph Hellwig Cc: linux-rdma@vger.kernel.org, timur@codeaurora.org, cov@codeaurora.org, Yishai Hadas , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH V2] net: ethernet: mellanox: correct page conversion In-Reply-To: <20160418121247.GA25387@infradead.org> References: <1460845412-13120-1-git-send-email-okaya@codeaurora.org> <20160418121247.GA25387@infradead.org> Message-ID: <0c6a430c5f0ec64f51d7c594ef9751dd@codeaurora.org> User-Agent: Roundcube Webmail/1.1.4 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 504 Lines: 13 On 2016-04-18 08:12, Christoph Hellwig wrote: > On Sat, Apr 16, 2016 at 06:23:32PM -0400, Sinan Kaya wrote: >> Current code is assuming that the address returned by >> dma_alloc_coherent >> is a logical address. This is not true on ARM/ARM64 systems. > > Can you explain what you mean with a 'logical address' and what actual > issue you're trying to solve? Vmap call is failing on arm64 systems because dma alloc api already returns an address mapped with vmap. Please see arch/arm64/mm directory.