Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752265AbcDRNyD (ORCPT ); Mon, 18 Apr 2016 09:54:03 -0400 Received: from mail1.bemta3.messagelabs.com ([195.245.230.165]:22439 "EHLO mail1.bemta3.messagelabs.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751363AbcDRNyB (ORCPT ); Mon, 18 Apr 2016 09:54:01 -0400 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprLIsWRWlGSWpSXmKPExsVyU6aHU/fLM5F wg7+H1Swu75rDZnFsgZgDk8fnTXIBjFGsmXlJ+RUJrBkfmppYCnpZK24tb2NuYJzG0sXIySEk sIFR4s55QRCbTcBMYterdewgtoiAjMTR/gVsIDazQKjE7Z/TwWxhgRiJ9fPfsXYxcnCwCKhK3 G2yAQnzCvhJ/Pg4lQUkLCEgJ7HgQjpEWFDi5MwnLBBTJCQOvnjBDLFVW2L5nj6wTRICChKzV2 1ggrBTJH4d+8cIYVtLtP39wD6BkW8WklGzkIxawMi0ilG9OLWoLLVI11gvqSgzPaMkNzEzR9f QwFgvN7W4ODE9NScxqVgvOT93EyMwqBiAYAdj8xenQ4ySHExKoryTVomEC/El5adUZiQWZ8QX leakFh9ilOHgUJLg3fIUKCdYlJqeWpGWmQMMb5i0BAePkgjvSZA0b3FBYm5xZjpE6hSjLseCH 7fXMgmx5OXnpUqJ824CKRIAKcoozYMbAYu1S4yyUsK8jEBHCfEUpBblZpagyr9iFOdgVBLmPQ cyhSczrwRu0yugI5iAjrB+IwhyREkiQkqqgTH7yYNllUq17oKb3kserNgfddVnv6adwIKOTmX vp9XfBHfrvBLxFFuSvmbV7X17OBg6/q5a265nOs1U0PHPL1au1PvrtSbxhUp7SbYVT9xgta1Z dI/4iobEd9Hl4bcD1rvtSr/M9rXKsyfbYTezmdT7jdovd3C8Ken231gx2yb+vVLuSdsNt5VYi jMSDbWYi4oTAfTfF5mwAgAA X-Env-Sender: andrew.goodbody@cambrionix.com X-Msg-Ref: server-14.tower-134.messagelabs.com!1460987636!26760506!1 X-Originating-IP: [217.28.140.9] X-StarScan-Received: X-StarScan-Version: 8.28; banners=-,-,- X-VirusChecked: Checked From: Andrew Goodbody To: CC: , Andrew Goodbody Subject: [PATCH v2 0/1] drivers: net: cpsw: Fix NULL pointer dereference with two slave PHYs Date: Mon, 18 Apr 2016 14:53:25 +0100 Message-ID: <1460987606-18125-1-git-send-email-andrew.goodbody@cambrionix.com> X-Mailer: git-send-email 2.5.0 MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [46.17.166.30] X-ClientProxiedBy: SEHSTE15FE05.hs20.net (172.18.251.45) To THHSTE15D2BE2.hs20.net (192.168.251.32) X-EXCLAIMER-MD-CONFIG: 266e7a57-cddd-49fd-bdea-19bca6d40303 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 652 Lines: 16 This is a fix for a NULL pointer dereference from cpsw which is triggered by having two slave PHYs attached to a cpsw network device. The problem is due to only maintaining a single reference to a PHY node in the prive data which gets overwritten by the second PHY probe. So move the PHY node reference to the individual slave data so that there is now one per slave. v1 had a problem that data->slaves was used before it had been filled in Andrew Goodbody (1): Prevent NUll pointer dereference with two PHYs on cpsw drivers/net/ethernet/ti/cpsw.c | 30 +++++++++++++++--------------- 1 file changed, 15 insertions(+), 15 deletions(-) -- 2.5.0