MIME-Version: 1.0
In-Reply-To: <CAMGffEm4AOZu+3=HxfNQVvvMuLkWWEDrTDrpqbSe3wX0u_=5cg@mail.gmail.com>
References: <CAMGffEmzO9nxs6cgcVYyKr-c1gW4oeQqVkn0oj1J5GiEWPy2PA@mail.gmail.com>
 <20160416015021.GA3694@infradead.org> <CAMGffEm4AOZu+3=HxfNQVvvMuLkWWEDrTDrpqbSe3wX0u_=5cg@mail.gmail.com>
From: Jinpu Wang <jinpu.wang@profitbricks.com>
Date: Mon, 18 Apr 2016 15:55:49 +0200
Message-ID: <CAMGffEmrDokDqcErAP9__xLD+jOp+i-TaF4+TCmxh-AcZSaTpw@mail.gmail.com>
Subject: Re: [PATCHv2]brd: set max_discard_sectors properly
To: Christoph Hellwig <hch@infradead.org>
Cc: Jens Axboe <axboe@fb.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset=UTF-8
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1264
Lines: 31

On Mon, Apr 18, 2016 at 10:34 AM, Jinpu Wang
<jinpu.wang@profitbricks.com> wrote:
> On Sat, Apr 16, 2016 at 3:50 AM, Christoph Hellwig <hch@infradead.org> wrote:
>>> -     blk_queue_max_discard_sectors(brd->brd_queue, UINT_MAX);
>>> +     blk_queue_max_discard_sectors(brd->brd_queue, UINT_MAX >> 9);
>>
>> Shouldn't we fix the issue by capping to UINT_MAX >> 9 inside
>> blk_queue_max_discard_sectors?  That way we'll prevent against having
>> issues like this in any other driver as well.
>
>
> Thanks Christoph, make sense to me, will rework it to this way.
>
> Regards,
> Jack
It turns out, the real fix is here:

commit 5e4298be45e83ecdffaabb370eea9396889b07f1
Author: Bart Van Assche <bart.vanassche@sandisk.com>
Date: Tue Dec 15 16:38:22 2015 +0100
brd: Fix discard request processing
Avoid that discard requests with size => PAGE_SIZE fail with
-EIO. Refuse discard requests if the discard size is not a
multiple of the page size.
Fixes: 2dbe54957636 ("brd: Refuse improperly aligned discard requests")
Signed-off-by: Bart Van Assche <bart.vanassche@sandisk.com>
Reviewed-by: Jan Kara <jack@suse.com>
Cc: Christoph Hellwig <hch@lst.de>
Cc: Robert Elliot <elliott@hp.com>
Cc: stable <stable@vger.kernel.org> # v4.4+
Signed-off-by: Jens Axboe <axboe@fb.com>