Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751773AbcDROnr (ORCPT ); Mon, 18 Apr 2016 10:43:47 -0400 Received: from mail.kernel.org ([198.145.29.136]:57996 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751054AbcDROnp (ORCPT ); Mon, 18 Apr 2016 10:43:45 -0400 Date: Mon, 18 Apr 2016 09:43:36 -0500 From: Bjorn Helgaas To: Joerg Roedel Cc: Bjorn Helgaas , stable@vger.kernel.org, =?utf-8?B?0J7Qu9C10LPQnNC+0YDQvtC3?= , "Rafael J. Wysocki" , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, Sunjin Yang , Rob Groner , Thomas Gleixner , Jiang Liu Subject: Re: [PATCH 0/3] v4.4: Revert "PCI: Implement pcibios_alloc_irq() and Message-ID: <20160418144336.GA17863@localhost> References: <20160413055439.6877.68183.stgit@bhelgaas-glaptop2.roam.corp.google.com> <20160414155044.GB3886@suse.de> <20160415150821.GA7973@localhost> <20160418115015.GE3886@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160418115015.GE3886@suse.de> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1034 Lines: 23 On Mon, Apr 18, 2016 at 01:50:15PM +0200, Joerg Roedel wrote: > Hi Bjorn, > > On Fri, Apr 15, 2016 at 10:08:21AM -0500, Bjorn Helgaas wrote: > > I assume you're thinking about doing pci_enable_resources() before > > the core calls the driver's probe method? One question there is how > > we would deal with pci_enable_device_mem(). If the core calls > > pci_enable_resources(), it has to assume the driver requires all BARs, > > and there are quite a few drivers that don't need the I/O BARs. > > Yes, I think that the problem might be fixed when the resources are > enabled during the pcibios-call. > > What do you think of enabling the the resources at probe time for the > pcibios-call and disable them afterwards? Then the driver can re-enable > whatever it needs and keep the rest disabled. That might work, but the problem seems to be that we aren't enabling IRQs correctly, so I'd rather have a fix that explicitly addresses IRQs than one that relies on some non-obvious connection between enabling BARs and IRQs. Bjorn