Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752879AbcDRPKu (ORCPT ); Mon, 18 Apr 2016 11:10:50 -0400 Received: from mail3-relais-sop.national.inria.fr ([192.134.164.104]:48915 "EHLO mail3-relais-sop.national.inria.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752783AbcDRPKs (ORCPT ); Mon, 18 Apr 2016 11:10:48 -0400 X-IronPort-AV: E=Sophos;i="5.24,503,1454972400"; d="scan'208";a="174949120" From: Julia Lawall To: Greg Kroah-Hartman Cc: kernel-janitors@vger.kernel.org, Jiri Slaby , linux-kernel@vger.kernel.org, "Luis R . Rodriguez" , Josh Triplett Subject: [PATCH 4/5] TTY: add __init attribute Date: Mon, 18 Apr 2016 16:55:37 +0200 Message-Id: <1460991338-9845-5-git-send-email-Julia.Lawall@lip6.fr> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1460991338-9845-1-git-send-email-Julia.Lawall@lip6.fr> References: <1460991338-9845-1-git-send-email-Julia.Lawall@lip6.fr> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1404 Lines: 38 Add __init attribute on a function that is only called from other __init functions and that is not inlined, at least with gcc version 4.8.4 on an x86 machine with allyesconfig. Currently, the function is put in the .text.unlikely segment. Declaring it as __init will cause it to be put in the .init.text and to disappear after initialization. The result of objdump -x on the function before the change is as follows: 000000000000014c l F .text.unlikely 0000000000000a2e init_r_port And after the change it is as follows: 0000000000000000 l F .init.text 0000000000000a29 init_r_port Done with the help of Coccinelle. The semantic patch checks for local static non-init functions that are called from an __init function and are not called from any other function. Signed-off-by: Julia Lawall --- drivers/tty/rocket.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/tty/rocket.c b/drivers/tty/rocket.c index 0b802cd..e979f2f 100644 --- a/drivers/tty/rocket.c +++ b/drivers/tty/rocket.c @@ -615,7 +615,8 @@ static void rp_do_poll(unsigned long dummy) * the board. * Inputs: board, aiop, chan numbers */ -static void init_r_port(int board, int aiop, int chan, struct pci_dev *pci_dev) +static void __init +init_r_port(int board, int aiop, int chan, struct pci_dev *pci_dev) { unsigned rocketMode; struct r_port *info;