Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752745AbcDRPKp (ORCPT ); Mon, 18 Apr 2016 11:10:45 -0400 Received: from mail3-relais-sop.national.inria.fr ([192.134.164.104]:35540 "EHLO mail3-relais-sop.national.inria.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751015AbcDRPKn (ORCPT ); Mon, 18 Apr 2016 11:10:43 -0400 X-IronPort-AV: E=Sophos;i="5.24,503,1454972400"; d="scan'208";a="174949117" From: Julia Lawall To: Michael Turquette Cc: kernel-janitors@vger.kernel.org, Stephen Boyd , linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, "Luis R . Rodriguez" , Josh Triplett Subject: [PATCH 1/5] clk: qoriq: add __init attribute Date: Mon, 18 Apr 2016 16:55:34 +0200 Message-Id: <1460991338-9845-2-git-send-email-Julia.Lawall@lip6.fr> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1460991338-9845-1-git-send-email-Julia.Lawall@lip6.fr> References: <1460991338-9845-1-git-send-email-Julia.Lawall@lip6.fr> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1384 Lines: 38 Add __init attribute on a function that is only called from other __init functions and that is not inlined, at least with gcc version 4.8.4 on an x86 machine with allyesconfig. Currently, the function is put in the .text.unlikely segment. Declaring it as __init will cause it to be put in the .init.text and to disappear after initialization. The result of objdump -x on the function before the change is as follows: 0000000000000000 l F .text.unlikely 0000000000000071 sysclk_from_fixed.constprop.5 And after the change it is as follows: 0000000000000480 l F .init.text 000000000000006c sysclk_from_fixed.constprop.5 Done with the help of Coccinelle. The semantic patch checks for local static non-init functions that are called from an __init function and are not called from any other function. Signed-off-by: Julia Lawall --- drivers/clk/clk-qoriq.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/clk/clk-qoriq.c b/drivers/clk/clk-qoriq.c index 7bc1c45..5c11b58 100644 --- a/drivers/clk/clk-qoriq.c +++ b/drivers/clk/clk-qoriq.c @@ -869,7 +869,8 @@ static void __init core_mux_init(struct device_node *np) } } -static struct clk *sysclk_from_fixed(struct device_node *node, const char *name) +static struct clk __init +*sysclk_from_fixed(struct device_node *node, const char *name) { u32 rate;