Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752729AbcDRPRK (ORCPT ); Mon, 18 Apr 2016 11:17:10 -0400 Received: from bombadil.infradead.org ([198.137.202.9]:34303 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752235AbcDRPRI (ORCPT ); Mon, 18 Apr 2016 11:17:08 -0400 Date: Mon, 18 Apr 2016 08:17:02 -0700 From: Christoph Hellwig To: Eli Cohen Cc: Christoph Hellwig , Sinan Kaya , "linux-rdma@vger.kernel.org" , "timur@codeaurora.org" , "cov@codeaurora.org" , Yishai Hadas , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH V2] net: ethernet: mellanox: correct page conversion Message-ID: <20160418151702.GA26565@infradead.org> References: <1460845412-13120-1-git-send-email-okaya@codeaurora.org> <20160418065447.GA11539@x-vnc01.mtx.labs.mlnx> <20160418143255.GA15203@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 305 Lines: 5 On Mon, Apr 18, 2016 at 02:39:36PM +0000, Eli Cohen wrote: > Right, I did not suggest this as a patch but just wanted to pinpoint the problematic issue which is that virt_to_page does not give you the correct pointer to the page. Removing both the virt_to_page + vmap calls would solve the issue indeed.