Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752451AbcDRPdY (ORCPT <rfc822;w@1wt.eu>);
	Mon, 18 Apr 2016 11:33:24 -0400
Received: from mail-wm0-f53.google.com ([74.125.82.53]:37711 "EHLO
	mail-wm0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751695AbcDRPdW (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Mon, 18 Apr 2016 11:33:22 -0400
Date: Mon, 18 Apr 2016 17:33:18 +0200
From: Thierry Reding <thierry.reding@gmail.com>
To: Jan Kiszka <jan.kiszka@siemens.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] scripts/gdb: Use $(abspath ...) instead of $(shell cd
 ... && pwd)
Message-ID: <20160418153318.GC22979@ulmo.ba.sec>
References: <1460106992-6864-1-git-send-email-thierry.reding@gmail.com>
 <570B2260.90704@siemens.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="IpbVkmxF4tDyP/Kb"
Content-Disposition: inline
In-Reply-To: <570B2260.90704@siemens.com>
User-Agent: Mutt/1.6.0 (2016-04-01)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 2216
Lines: 64


--IpbVkmxF4tDyP/Kb
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Sun, Apr 10, 2016 at 09:04:48PM -0700, Jan Kiszka wrote:
> On 2016-04-08 02:16, Thierry Reding wrote:
> > From: Thierry Reding <treding@nvidia.com>
> >=20
> > Avoid forking off a shell to resolve the absolute path of the output
> > directory when make's builtin $(abspath ...) function will do an
> > adequate job.
> >=20
> > Signed-off-by: Thierry Reding <treding@nvidia.com>
> > ---
> >  scripts/gdb/linux/Makefile | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >=20
> > diff --git a/scripts/gdb/linux/Makefile b/scripts/gdb/linux/Makefile
> > index 6cf1ecf61057..d8b88e22e16a 100644
> > --- a/scripts/gdb/linux/Makefile
> > +++ b/scripts/gdb/linux/Makefile
> > @@ -1,6 +1,6 @@
> >  always :=3D gdb-scripts
> > =20
> > -SRCTREE :=3D $(shell cd $(srctree) && /bin/pwd)
> > +SRCTREE :=3D $(abspath $(srctree))
> > =20
> >  $(obj)/gdb-scripts:
> >  ifneq ($(KBUILD_SRC),)
> >=20
>=20
> Thanks, good cleanup. Queued.

You might want to remove this, if it's not too late yet. I posted
another similar thread and people objected to it because it requires
GNU make 3.81, whereas the kernel build process officially still
supports 3.80.

Thierry

--IpbVkmxF4tDyP/Kb
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQIcBAABCAAGBQJXFP4+AAoJEN0jrNd/PrOhlFEP/iWEj7FBY6uFhgTA5QljEd/S
Nov7fbxpPsNo2DQWK4+1le/+pyDoEYcsLQaGzW0BMlsR0aSzTrl3iTqzkvVxQwsw
tPweYqVCjxHYKGml1c/7Uwd3sgc0W72S3j0uG5bCDJ0sfgClm0qxKJY6dgnOPAgP
MWNRGmmgAsctOcKjINC4hM8kvKhcQKHqnn/yPShVsuK0sWUnGxC2rQ6jTQuHzCmv
wL5h54eSxreFQLnNSuoDtVLFBMVASseTpoEjGyV2yPFPPMJ3HTVkNIb2LHuMfTS0
tJ48MWZqYgSoxY3xwQfRRQXwEfa7OVlNt6+PpOJnFB8jzN5mZimh63dB0EQkFyu6
nTsBFgT7wTH2KOooUVHgT9YMlp6qcfvsNEFZEWmP7k4Hqtv+418I97QQ2nPqPx+G
thod+yu+S7jKKdA/bcvPG/zoJ8CENYF+7noUTFS8a+1xJLgqm7lttAE+GbuPbC48
57fxqdEx7L+AcLo6BzAo+V150p13JNbwwoW9KhTs6SFusPN3aKgUPu1S/TAomgTg
ta0/PFF3mL17UOMPm51CWLMbjKdLvUX+m2rsYWhL/SAzxWZCiM0YHNzgiITaoauh
WD7b95MWZzuC4LwZHT7+b/l9c3XFV4iAOjsjKvlG+8h22yqilbFACEh2kxzxWQ4U
F1AFuKzaR/XjnMlhY3Tm
=Kcl+
-----END PGP SIGNATURE-----

--IpbVkmxF4tDyP/Kb--