Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752364AbcDRPgJ (ORCPT ); Mon, 18 Apr 2016 11:36:09 -0400 Received: from foss.arm.com ([217.140.101.70]:34784 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751695AbcDRPgI (ORCPT ); Mon, 18 Apr 2016 11:36:08 -0400 Date: Mon, 18 Apr 2016 16:35:41 +0100 From: Mark Rutland To: Ard Biesheuvel Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, will.deacon@arm.com, james.morse@arm.com, catalin.marinas@arm.com Subject: Re: [PATCH 1/8] arm64: kernel: don't export local symbols from head.S Message-ID: <20160418153540.GA7521@leverpostej> References: <1460992188-23295-1-git-send-email-ard.biesheuvel@linaro.org> <1460992188-23295-2-git-send-email-ard.biesheuvel@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1460992188-23295-2-git-send-email-ard.biesheuvel@linaro.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1449 Lines: 50 On Mon, Apr 18, 2016 at 05:09:41PM +0200, Ard Biesheuvel wrote: > This unexports some symbols from head.S that are only used locally. It might be worth s/some/all/, as that makes this sound less arbitrary (and AFAICS this caters for all symbols only used locally). > Signed-off-by: Ard Biesheuvel Acked-by: Mark Rutland Mark. > --- > arch/arm64/kernel/head.S | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/arch/arm64/kernel/head.S b/arch/arm64/kernel/head.S > index b43417618847..ac27d8d937b2 100644 > --- a/arch/arm64/kernel/head.S > +++ b/arch/arm64/kernel/head.S > @@ -638,7 +638,7 @@ ENDPROC(el2_setup) > * Sets the __boot_cpu_mode flag depending on the CPU boot mode passed > * in x20. See arch/arm64/include/asm/virt.h for more info. > */ > -ENTRY(set_cpu_boot_mode_flag) > +set_cpu_boot_mode_flag: > adr_l x1, __boot_cpu_mode > cmp w20, #BOOT_CPU_MODE_EL2 > b.ne 1f > @@ -691,7 +691,7 @@ ENTRY(secondary_entry) > b secondary_startup > ENDPROC(secondary_entry) > > -ENTRY(secondary_startup) > +secondary_startup: > /* > * Common entry point for secondary CPUs. > */ > @@ -706,7 +706,7 @@ ENTRY(secondary_startup) > ENDPROC(secondary_startup) > 0: .long (_text - TEXT_OFFSET) - __secondary_switched > > -ENTRY(__secondary_switched) > +__secondary_switched: > adr_l x5, vectors > msr vbar_el1, x5 > isb > -- > 2.5.0 >