Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752761AbcDRPvk (ORCPT ); Mon, 18 Apr 2016 11:51:40 -0400 Received: from goliath.siemens.de ([192.35.17.28]:35228 "EHLO goliath.siemens.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751332AbcDRPvi (ORCPT ); Mon, 18 Apr 2016 11:51:38 -0400 Subject: Re: [PATCH] scripts/gdb: Use $(abspath ...) instead of $(shell cd ... && pwd) To: Thierry Reding References: <1460106992-6864-1-git-send-email-thierry.reding@gmail.com> <570B2260.90704@siemens.com> <20160418153318.GC22979@ulmo.ba.sec> Cc: linux-kernel@vger.kernel.org From: Jan Kiszka Message-ID: <57150287.60404@siemens.com> Date: Mon, 18 Apr 2016 17:51:35 +0200 User-Agent: Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12) Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666 MIME-Version: 1.0 In-Reply-To: <20160418153318.GC22979@ulmo.ba.sec> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1450 Lines: 46 On 2016-04-18 17:33, Thierry Reding wrote: > On Sun, Apr 10, 2016 at 09:04:48PM -0700, Jan Kiszka wrote: >> On 2016-04-08 02:16, Thierry Reding wrote: >>> From: Thierry Reding >>> >>> Avoid forking off a shell to resolve the absolute path of the output >>> directory when make's builtin $(abspath ...) function will do an >>> adequate job. >>> >>> Signed-off-by: Thierry Reding >>> --- >>> scripts/gdb/linux/Makefile | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/scripts/gdb/linux/Makefile b/scripts/gdb/linux/Makefile >>> index 6cf1ecf61057..d8b88e22e16a 100644 >>> --- a/scripts/gdb/linux/Makefile >>> +++ b/scripts/gdb/linux/Makefile >>> @@ -1,6 +1,6 @@ >>> always := gdb-scripts >>> >>> -SRCTREE := $(shell cd $(srctree) && /bin/pwd) >>> +SRCTREE := $(abspath $(srctree)) >>> >>> $(obj)/gdb-scripts: >>> ifneq ($(KBUILD_SRC),) >>> >> >> Thanks, good cleanup. Queued. > > You might want to remove this, if it's not too late yet. I posted Still in my queue only. > another similar thread and people objected to it because it requires > GNU make 3.81, whereas the kernel build process officially still > supports 3.80. Hmm, I scanned the kernel for this pattern before, and there were hits... ah, only in tools/, not in the main build. OK, will drop again. Jan -- Siemens AG, Corporate Technology, CT RDA ITP SES-DE Corporate Competence Center Embedded Linux