Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752813AbcDRPvs (ORCPT ); Mon, 18 Apr 2016 11:51:48 -0400 Received: from mail-wm0-f53.google.com ([74.125.82.53]:36402 "EHLO mail-wm0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751332AbcDRPvp (ORCPT ); Mon, 18 Apr 2016 11:51:45 -0400 Subject: Re: [PATCH 3/5] clocksource/drivers/mtk_timer: add __init attribute To: Julia Lawall , Daniel Lezcano References: <1460991338-9845-1-git-send-email-Julia.Lawall@lip6.fr> <1460991338-9845-4-git-send-email-Julia.Lawall@lip6.fr> Cc: kernel-janitors@vger.kernel.org, Thomas Gleixner , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, "Luis R . Rodriguez" , Josh Triplett From: Matthias Brugger Message-ID: <5715028D.4020300@gmail.com> Date: Mon, 18 Apr 2016 17:51:41 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.7.0 MIME-Version: 1.0 In-Reply-To: <1460991338-9845-4-git-send-email-Julia.Lawall@lip6.fr> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1650 Lines: 44 On 18/04/16 16:55, Julia Lawall wrote: > Add __init attribute on a function that is only called from other __init > functions and that is not inlined, at least with gcc version 4.8.4 on an > x86 machine with allyesconfig. Currently, the function is put in the > .text.unlikely segment. Declaring it as __init will cause it to be put in > the .init.text and to disappear after initialization. > > The result of objdump -x on the function before the change is as follows: > > 0000000000000000 l F .text.unlikely 000000000000006f mtk_timer_setup.isra.4 > > And after the change it is as follows: > > 0000000000000000 l F .init.text 000000000000006a mtk_timer_setup.isra.4 > > Done with the help of Coccinelle. The semantic patch checks for local > static non-init functions that are called from an __init function and are > not called from any other function. > > Signed-off-by: Julia Lawall > Acked-by: Matthias Brugger > --- > drivers/clocksource/mtk_timer.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/clocksource/mtk_timer.c b/drivers/clocksource/mtk_timer.c > index d67bc35..7e583f8 100644 > --- a/drivers/clocksource/mtk_timer.c > +++ b/drivers/clocksource/mtk_timer.c > @@ -152,7 +152,7 @@ static irqreturn_t mtk_timer_interrupt(int irq, void *dev_id) > } > > static void > -mtk_timer_setup(struct mtk_clock_event_device *evt, u8 timer, u8 option) > +__init mtk_timer_setup(struct mtk_clock_event_device *evt, u8 timer, u8 option) > { > writel(TIMER_CTRL_CLEAR | TIMER_CTRL_DISABLE, > evt->gpt_base + TIMER_CTRL_REG(timer)); >