Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752860AbcDRQ36 (ORCPT ); Mon, 18 Apr 2016 12:29:58 -0400 Received: from avon.wwwdotorg.org ([70.85.31.133]:54270 "EHLO avon.wwwdotorg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751669AbcDRQ34 (ORCPT ); Mon, 18 Apr 2016 12:29:56 -0400 Subject: Re: [PATCH 2/3] gpio: tegra: Remove the need of keeping device handle for gpio driver To: Laxman Dewangan , linus.walleij@linaro.org References: <1460969178-20914-1-git-send-email-ldewangan@nvidia.com> <1460969178-20914-2-git-send-email-ldewangan@nvidia.com> Cc: gnurou@gmail.com, thierry.reding@gmail.com, linux-gpio@vger.kernel.org, linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org From: Stephen Warren Message-ID: <57150B81.6040104@wwwdotorg.org> Date: Mon, 18 Apr 2016 10:29:53 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: <1460969178-20914-2-git-send-email-ldewangan@nvidia.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 375 Lines: 8 On 04/18/2016 02:46 AM, Laxman Dewangan wrote: > Remove the file static device handle variable as this is just > required for prints. The required handle can be stored in > tegra_gpio_chip and hence it become redundancy. This seems fine as far as it goes, but if it's worth doing this, please move all the globals into the GPIO chip rather than just one of the 7 globals.