Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753248AbcDRQxh (ORCPT ); Mon, 18 Apr 2016 12:53:37 -0400 Received: from mail.kernel.org ([198.145.29.136]:42853 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752657AbcDRQxf (ORCPT ); Mon, 18 Apr 2016 12:53:35 -0400 Date: Mon, 18 Apr 2016 11:53:29 -0500 From: Rob Herring To: Peter Griffin Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, broonie@kernel.org, lgirdwood@gmail.com, srinivas.kandagatla@gmail.com, maxime.coquelin@st.com, patrice.chotard@st.com, lee.jones@linaro.org, devicetree@vger.kernel.org Subject: Re: [PATCH 1/5] regulator: st-flashss: Add DT binding documentation for flashss regulator. Message-ID: <20160418165329.GA8367@rob-hp-laptop> References: <1460474204-5351-1-git-send-email-peter.griffin@linaro.org> <1460474204-5351-2-git-send-email-peter.griffin@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1460474204-5351-2-git-send-email-peter.griffin@linaro.org> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1762 Lines: 44 On Tue, Apr 12, 2016 at 04:16:40PM +0100, Peter Griffin wrote: > This patch adds the DT doc for the flashss regulator driver which is > found in stih407 based silicon. > > Signed-off-by: Peter Griffin > --- > .../devicetree/bindings/regulator/st-flashss.txt | 43 ++++++++++++++++++++++ > 1 file changed, 43 insertions(+) > create mode 100644 Documentation/devicetree/bindings/regulator/st-flashss.txt > > diff --git a/Documentation/devicetree/bindings/regulator/st-flashss.txt b/Documentation/devicetree/bindings/regulator/st-flashss.txt > new file mode 100644 > index 0000000..04324d5 > --- /dev/null > +++ b/Documentation/devicetree/bindings/regulator/st-flashss.txt > @@ -0,0 +1,43 @@ > +ST Voltage regulator for FlashSS vsense > + > +This documents the voltage regulator driver which manages the vsense inside the ST flash Bindings document h/w, not drivers. > +sub-system that is used for configuring MMC, NAND, SPI voltages. > + > +Required properties: > +- compatible: Can be "st,vqmmc", "st,vnand" or "st,vspi" because it is shared > + among these devices inside the ST FlashSS. > +- regulator-name: Regulator name. > +- reg: The vsense top config base address in the flashSS hardware. > + > +Any property defined as part of the core regulator binding, in > +Documentation/devicetree/bindings/regulator/regulator.txt can also be used. > + > +Example: > + > +vqmmc_reg: voltage-regulator { > + compatible = "st,vqmmc"; > + regulator-name = "vqmmc0"; > + /* Control register for the VSENSE Module */ I'm having a hard time understanding the relationship of FlashSS, VSENSE and the compatible strings. The binding looks suspect to me though. If VSENSE is a module, then I'd expect a compatible string for it. Rob