Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753286AbcDRQyi (ORCPT <rfc822;w@1wt.eu>);
	Mon, 18 Apr 2016 12:54:38 -0400
Received: from mail-oi0-f50.google.com ([209.85.218.50]:35591 "EHLO
	mail-oi0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751682AbcDRQyg (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Mon, 18 Apr 2016 12:54:36 -0400
MIME-Version: 1.0
In-Reply-To: <50b61ce23a73b68c3c55d6d9aa416af29001205a.1438170155.git.baolin.wang@linaro.org>
References: <cover.1438170154.git.baolin.wang@linaro.org>
	<50b61ce23a73b68c3c55d6d9aa416af29001205a.1438170155.git.baolin.wang@linaro.org>
Date: Mon, 18 Apr 2016 09:54:35 -0700
Message-ID: <CALAqxLXi=+1fOmabeO9o4q_mOcGuDFdxEvEvz3dWEW+g0fkVHw@mail.gmail.com>
Subject: Re: [RESEND PATCH v2 3/5] security: Introduce security_settime64()
From: John Stultz <john.stultz@linaro.org>
To: Baolin Wang <baolin.wang@linaro.org>
Cc: Serge Hallyn <serge.hallyn@canonical.com>, james.l.morris@oracle.com,
        serge@hallyn.com, Thomas Gleixner <tglx@linutronix.de>,
        pmoore@redhat.com, sds@tycho.nsa.gov,
        Kees Cook <keescook@chromium.org>, john.johansen@canonical.com,
        casey@schaufler-ca.com, agruenba@redhat.com,
        Alexander Viro <viro@zeniv.linux.org.uk>, Neil Brown <neilb@suse.de>,
        jann@thejh.net, Mark Brown <broonie@kernel.org>,
        Christopher Hall <christopher.s.hall@intel.com>,
        Xunlei Pang <pang.xunlei@linaro.org>, Harald Geyer <harald@ccbib.org>,
        Arnd Bergmann <arnd@arndb.de>, lkml <linux-kernel@vger.kernel.org>,
        LSM List <linux-security-module@vger.kernel.org>
Content-Type: text/plain; charset=UTF-8
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 967
Lines: 29

On Thu, Apr 7, 2016 at 11:02 PM, Baolin Wang <baolin.wang@linaro.org> wrote:
> security_settime() uses a timespec, which is not year 2038 safe
> on 32bit systems. Thus this patch introduces the security_settime64()
> function with timespec64 type. We also convert the cap_settime() helper
> function to use the 64bit types.
>
> Move the security_settime() to the head file as a inline function for
> removing that inline helper when following up patches are fixed the
> call sites.
>
> None of the existing hooks is using the timespec argument and therefor
> the patch is not doing any functional changes.
>
> Signed-off-by: Baolin Wang <baolin.wang@linaro.org>

Hey Baolin,
  If you get an ack, like you did from James, please include it in the
commit message of following submissions

Serge, Kees: Any objection to this patch going in via the
tip/timers/core tree with the dependent settimeofday64 call?

Otherwise I'll queue this up for testing.

thanks
-john


.