Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753207AbcDRRFE (ORCPT ); Mon, 18 Apr 2016 13:05:04 -0400 Received: from mail-wm0-f41.google.com ([74.125.82.41]:38824 "EHLO mail-wm0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751726AbcDRRFB (ORCPT ); Mon, 18 Apr 2016 13:05:01 -0400 MIME-Version: 1.0 In-Reply-To: References: <50b61ce23a73b68c3c55d6d9aa416af29001205a.1438170155.git.baolin.wang@linaro.org> Date: Mon, 18 Apr 2016 10:04:58 -0700 X-Google-Sender-Auth: vomFfkYMNWpz2SsQpXyyul9GXFo Message-ID: Subject: Re: [RESEND PATCH v2 3/5] security: Introduce security_settime64() From: Kees Cook To: John Stultz Cc: Baolin Wang , Serge Hallyn , James Morris , "Serge E. Hallyn" , Thomas Gleixner , Paul Moore , Stephen Smalley , John Johansen , Casey Schaufler , Andreas Gruenbacher , Alexander Viro , Neil Brown , Jann Horn , Mark Brown , Christopher Hall , Xunlei Pang , Harald Geyer , Arnd Bergmann , lkml , LSM List Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1206 Lines: 41 On Mon, Apr 18, 2016 at 9:54 AM, John Stultz wrote: > On Thu, Apr 7, 2016 at 11:02 PM, Baolin Wang wrote: >> security_settime() uses a timespec, which is not year 2038 safe >> on 32bit systems. Thus this patch introduces the security_settime64() >> function with timespec64 type. We also convert the cap_settime() helper >> function to use the 64bit types. >> >> Move the security_settime() to the head file as a inline function for >> removing that inline helper when following up patches are fixed the >> call sites. >> >> None of the existing hooks is using the timespec argument and therefor >> the patch is not doing any functional changes. >> >> Signed-off-by: Baolin Wang > > Hey Baolin, > If you get an ack, like you did from James, please include it in the > commit message of following submissions > > Serge, Kees: Any objection to this patch going in via the > tip/timers/core tree with the dependent settimeofday64 call? No problem from me: makes sense to keep it all together in one tree. -Kees > > Otherwise I'll queue this up for testing. > > thanks > -john > > > . -- Kees Cook Chrome OS & Brillo Security