MIME-Version: 1.0
In-Reply-To: <CALAqxLXi=+1fOmabeO9o4q_mOcGuDFdxEvEvz3dWEW+g0fkVHw@mail.gmail.com>
References: <cover.1438170154.git.baolin.wang@linaro.org>
	<50b61ce23a73b68c3c55d6d9aa416af29001205a.1438170155.git.baolin.wang@linaro.org>
	<CALAqxLXi=+1fOmabeO9o4q_mOcGuDFdxEvEvz3dWEW+g0fkVHw@mail.gmail.com>
Date: Mon, 18 Apr 2016 10:04:58 -0700
Message-ID: <CAGXu5jJ=NYH-LadHo4dGz-sHvUT+Q38Vq9c5TTq7sr4QrUhQDg@mail.gmail.com>
Subject: Re: [RESEND PATCH v2 3/5] security: Introduce security_settime64()
From: Kees Cook <keescook@chromium.org>
To: John Stultz <john.stultz@linaro.org>
Cc: Baolin Wang <baolin.wang@linaro.org>,
        Serge Hallyn <serge.hallyn@canonical.com>,
        James Morris <james.l.morris@oracle.com>,
        "Serge E. Hallyn" <serge@hallyn.com>,
        Thomas Gleixner <tglx@linutronix.de>, Paul Moore <pmoore@redhat.com>,
        Stephen Smalley <sds@tycho.nsa.gov>,
        John Johansen <john.johansen@canonical.com>,
        Casey Schaufler <casey@schaufler-ca.com>,
        Andreas Gruenbacher <agruenba@redhat.com>,
        Alexander Viro <viro@zeniv.linux.org.uk>, Neil Brown <neilb@suse.de>,
        Jann Horn <jann@thejh.net>, Mark Brown <broonie@kernel.org>,
        Christopher Hall <christopher.s.hall@intel.com>,
        Xunlei Pang <pang.xunlei@linaro.org>, Harald Geyer <harald@ccbib.org>,
        Arnd Bergmann <arnd@arndb.de>, lkml <linux-kernel@vger.kernel.org>,
        LSM List <linux-security-module@vger.kernel.org>
Content-Type: text/plain; charset=UTF-8
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1206
Lines: 41

On Mon, Apr 18, 2016 at 9:54 AM, John Stultz <john.stultz@linaro.org> wrote:
> On Thu, Apr 7, 2016 at 11:02 PM, Baolin Wang <baolin.wang@linaro.org> wrote:
>> security_settime() uses a timespec, which is not year 2038 safe
>> on 32bit systems. Thus this patch introduces the security_settime64()
>> function with timespec64 type. We also convert the cap_settime() helper
>> function to use the 64bit types.
>>
>> Move the security_settime() to the head file as a inline function for
>> removing that inline helper when following up patches are fixed the
>> call sites.
>>
>> None of the existing hooks is using the timespec argument and therefor
>> the patch is not doing any functional changes.
>>
>> Signed-off-by: Baolin Wang <baolin.wang@linaro.org>
>
> Hey Baolin,
>   If you get an ack, like you did from James, please include it in the
> commit message of following submissions
>
> Serge, Kees: Any objection to this patch going in via the
> tip/timers/core tree with the dependent settimeofday64 call?

No problem from me: makes sense to keep it all together in one tree.

-Kees

>
> Otherwise I'll queue this up for testing.
>
> thanks
> -john
>
>
> .


-- 
Kees Cook
Chrome OS & Brillo Security